From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULEYf-0007XP-Us for qemu-devel@nongnu.org; Thu, 28 Mar 2013 11:16:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULEYa-00067N-Tt for qemu-devel@nongnu.org; Thu, 28 Mar 2013 11:16:05 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48515 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULEYa-000674-1V for qemu-devel@nongnu.org; Thu, 28 Mar 2013 11:16:00 -0400 Message-ID: <51545EAE.6010909@suse.de> Date: Thu, 28 Mar 2013 16:15:58 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1363358063-23973-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anthony Liguori , patches@linaro.org, qemu-devel@nongnu.org, Michael Walle , Jan Kiszka , Paolo Bonzini Am 28.03.2013 12:25, schrieb Peter Maydell: > Ping! All patches have at least one Reviewed-by or Acked-by including that of the lm32 maintainer, so you could just apply these to arm-devs.next, no? Andreas >=20 > -- PMM >=20 > On 15 March 2013 14:34, Peter Maydell wrote: >> The functions sysbus_add_memory and sysbus_del_memory are odd wrappers >> around around memory_region_add/del_subregion, and their presence >> is an encouragement to devices to try to map their own memory >> regions into the system address space. >> >> Since they're only used in a couple of places in the milkymist >> and musicpal platforms, rewrite those uses to have the sysbus >> devices expose the memory regions as sysbus mmio regions, and >> then have the creator of the device (ie board code) map them >> in the right places. Then we can remove the functions altogether. >> >> The series includes a trivial patch to sysbus to make the init >> method optional, since (as part of the move towards using only >> instance_init and realize) it's now possible to have a simple >> functional device which only needs an instance_init method >> and no realize or init [the musicpal-misc device introduced >> in patch 2 being one such example]. >> >> Tested on both musicpal and milkymist. >> >> I rather suspect sysbus_add_io and sysbus_del_io should also be >> removed, but since their users are in PPC and x86 platforms I'll >> let somebody else do that part :-) >> >> Changes v2->v3: >> * changed field name of parent obj in MusicPalMiscState to >> 'parent_obj' as per convention >> * rebased on master >> Changes v1->v2: >> * updated 'qdevify musicpal-misc' to drop unneeded typedef >> and QOM macros, as per review discussion >> >> >> Peter Maydell (5): >> sysbus: make SysBusDeviceClass::init optional >> musicpal: qdevify musicpal-misc >> milkymist-minimac2: Just expose buffers as a sysbus mmio region >> milkymist-softusb: Don't map RAM memory regions in the device itself >> sysbus: Remove sysbus_add_memory and sysbus_del_memory >> >> hw/arm/musicpal.c | 28 +++++++++++++++++++++++----- >> hw/milkymist-hw.h | 6 +++--- >> hw/milkymist-minimac2.c | 5 +---- >> hw/milkymist-softusb.c | 21 +++++++++++---------- >> hw/sysbus.c | 21 +++------------------ >> hw/sysbus.h | 5 ----- >> 6 files changed, 41 insertions(+), 45 deletions(-) >> >> -- >> 1.7.9.5 >> >> >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg