From: Richard Henderson <rth@twiddle.net>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] tci: Use 32-bit signed offsets to loads/stores
Date: Thu, 28 Mar 2013 08:56:40 -0700 [thread overview]
Message-ID: <51546838.5000201@twiddle.net> (raw)
In-Reply-To: <515465B6.8050109@weilnetz.de>
On 03/28/2013 08:45 AM, Stefan Weil wrote:
>> > - t2 = tci_read_i32(&tb_ptr);
>> > + t2 = tci_read_s32(&tb_ptr);
> I'm afraid that old and new generated code are identical,
> because t2 is an unsigned tcg_target_ulong.
No it's not, because s32 is sign-extended from int32_t to tcg_target_ulong.
If you're thinking of the later arithmetic in type tcg_target_ulong, that's
fine. Just so long as the sign-extension happened first.
r~
next prev parent reply other threads:[~2013-03-28 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 15:37 [Qemu-devel] [PATCH 0/5] Fixes and minor improvements to TCI Richard Henderson
2013-03-28 15:37 ` [Qemu-devel] [PATCH 1/5] tci: Use 32-bit signed offsets to loads/stores Richard Henderson
2013-03-28 15:45 ` Stefan Weil
2013-03-28 15:56 ` Richard Henderson [this message]
2013-03-28 15:37 ` [Qemu-devel] [PATCH 2/5] tci: Use a local variable for env Richard Henderson
2013-03-28 15:52 ` Stefan Weil
2013-03-28 15:37 ` [Qemu-devel] [PATCH 3/5] tci: Avoid code before declarations Richard Henderson
2013-03-28 15:37 ` [Qemu-devel] [PATCH 4/5] tci: Delete unused tb_ret_addr Richard Henderson
2013-03-28 15:37 ` [Qemu-devel] [PATCH 5/5] tci: Make tcg temporaries local to tcg_qemu_tb_exec Richard Henderson
2013-04-03 22:11 ` [Qemu-devel] [PATCH 0/5] Fixes and minor improvements to TCI Richard Henderson
2013-04-09 11:37 ` Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2013-04-11 18:15 [Qemu-devel] [PULL] " Stefan Weil
2013-04-11 18:15 ` [Qemu-devel] [PATCH 1/5] tci: Use 32-bit signed offsets to loads/stores Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51546838.5000201@twiddle.net \
--to=rth@twiddle.net \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).