From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULFC6-0004Ym-Pb for qemu-devel@nongnu.org; Thu, 28 Mar 2013 11:56:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULFC2-0003N3-7E for qemu-devel@nongnu.org; Thu, 28 Mar 2013 11:56:50 -0400 Received: from mail-ob0-x235.google.com ([2607:f8b0:4003:c01::235]:50523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULFC2-0003Mq-1p for qemu-devel@nongnu.org; Thu, 28 Mar 2013 11:56:46 -0400 Received: by mail-ob0-f181.google.com with SMTP id ni5so9457712obc.12 for ; Thu, 28 Mar 2013 08:56:45 -0700 (PDT) Sender: Richard Henderson Message-ID: <51546838.5000201@twiddle.net> Date: Thu, 28 Mar 2013 08:56:40 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1364485075-17899-1-git-send-email-rth@twiddle.net> <1364485075-17899-2-git-send-email-rth@twiddle.net> <515465B6.8050109@weilnetz.de> In-Reply-To: <515465B6.8050109@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] tci: Use 32-bit signed offsets to loads/stores List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org On 03/28/2013 08:45 AM, Stefan Weil wrote: >> > - t2 = tci_read_i32(&tb_ptr); >> > + t2 = tci_read_s32(&tb_ptr); > I'm afraid that old and new generated code are identical, > because t2 is an unsigned tcg_target_ulong. No it's not, because s32 is sign-extended from int32_t to tcg_target_ulong. If you're thinking of the later arithmetic in type tcg_target_ulong, that's fine. Just so long as the sign-extension happened first. r~