From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULFVB-0006Mf-U1 for qemu-devel@nongnu.org; Thu, 28 Mar 2013 12:16:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULFV5-0001wn-Cy for qemu-devel@nongnu.org; Thu, 28 Mar 2013 12:16:33 -0400 Received: from mail-oa0-f49.google.com ([209.85.219.49]:41176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULFV5-0001wj-89 for qemu-devel@nongnu.org; Thu, 28 Mar 2013 12:16:27 -0400 Received: by mail-oa0-f49.google.com with SMTP id j6so9961220oag.8 for ; Thu, 28 Mar 2013 09:16:26 -0700 (PDT) Sender: Richard Henderson Message-ID: <51546CD6.4070303@twiddle.net> Date: Thu, 28 Mar 2013 09:16:22 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1364484781-15561-1-git-send-email-rth@twiddle.net> <1364484781-15561-6-git-send-email-rth@twiddle.net> <515469F1.2020204@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 05/20] tcg-arm: Handle constant arguments to add2/sub2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Desnogues Cc: Peter Maydell , qemu-devel@nongnu.org, Aurelien Jarno On 03/28/2013 09:09 AM, Laurent Desnogues wrote: >> I think it actually makes everything a lot cleaner myself. Especially given >> the previous definition that required runtime checks for TST et al. > > I also find this cleaner. OTOH I understand that Peter finds it > odd given that other operations (such as ADD) can optionally > set flags. Well of course they can. Which is exactly why I'm doing all this, because I can include that bit in the add2/sub2 expansion below. It's just that the comparison insns *require* the S bit set, which is what is going on in this enum. r~