From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43484)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1ULFhE-0003mD-Lu
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 12:29:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1ULFhC-0006DC-DQ
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 12:29:00 -0400
Received: from e9.ny.us.ibm.com ([32.97.182.139]:38589)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1ULFhC-0006D1-9a
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 12:28:58 -0400
Received: from /spool/local
	by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <stefanb@linux.vnet.ibm.com>;
	Thu, 28 Mar 2013 12:28:57 -0400
Message-ID: <51546FC5.5010909@linux.vnet.ibm.com>
Date: Thu, 28 Mar 2013 12:28:53 -0400
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1364483920.28637.3.camel@d941e-10>
	<20130328152916.GA31205@stefanha-thinkpad.redhat.com>
In-Reply-To: <20130328152916.GA31205@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] Fix some memory leaks in
	test-visitor-serialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 03/28/2013 11:29 AM, Stefan Hajnoczi wrote:
> On Thu, Mar 28, 2013 at 11:18:40AM -0400, Stefan Berger wrote:
>> This patch fixes some of the memory leaks in test-visitor-serialization but not all of them.
>>
>> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>>
>> ---
>>   v2->v3: repost
>>
>>   v1->v2: call qobject_decref(obj) earlier
>>
>> ---
>>   tests/test-visitor-serialization.c |   12 +++++++++++-
>>   1 file changed, 11 insertions(+), 1 deletion(-)
> Thanks, applied to the trivial patches -next tree:
> https://github.com/stefanha/qemu/commits/trivial-patches-next
>
> Stefan
>
Great. There are some left-over leaks that I couldn't figure out how to 
fix. Someone more familiar with the qmp code may want to look at them.