From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULKaJ-0006cg-U2 for qemu-devel@nongnu.org; Thu, 28 Mar 2013 17:42:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULKaD-0007zQ-J4 for qemu-devel@nongnu.org; Thu, 28 Mar 2013 17:42:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULKaD-0007z8-AH for qemu-devel@nongnu.org; Thu, 28 Mar 2013 17:42:05 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2SLg49k032108 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 28 Mar 2013 17:42:04 -0400 Message-ID: <5154B92B.9030604@redhat.com> Date: Thu, 28 Mar 2013 15:42:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <624f54b5c269178e6fb4b212de05ceda59c3d009.1364487348.git.phrdina@redhat.com> In-Reply-To: <624f54b5c269178e6fb4b212de05ceda59c3d009.1364487348.git.phrdina@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2EFXTKLMIVFRRMGGPRLWV" Subject: Re: [Qemu-devel] [PATCH v3 08/11] qemu-img: introduce qemu_img_handle_error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2EFXTKLMIVFRRMGGPRLWV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/28/2013 10:47 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > qemu-img.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake > +static int qemu_img_handle_error(Error *err) > +{ > + if (error_is_set(&err)) { > + error_report("%s", error_get_pretty(err)); > + error_free(err); > + return 1; A non-bool positive number is unusual for errors (-1, or a true/false scheme, tend to be more common)... > - if (error_is_set(&local_err)) { > - error_report("%s", error_get_pretty(local_err)); > - error_free(local_err); > - return 1; =2E..but it is accurate code motion, so it doesn't impact my review. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2EFXTKLMIVFRRMGGPRLWV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRVLkrAAoJEKeha0olJ0Nq6cQH/0cA1r2ywS2zJ7kxUerxnPA6 XPas3U84laCpIvGsuGdTDAZyMpNNFAnThZWwsXwpeOsUZEd2R7kXftE9RKNwFxs7 4ASLdCeI8aR1Z9g0R3FVKQQvRs3K5ByXUBcxO3q3Udz0tOxILPBzwGQknti+qsoD b35H7uGtAcA6YRN6AZkKjxGkKxY6zhM+UfK7BKzHZzNon6Qht6OMxKPvLygAujz6 J1zYjXzRGOmzdb1Rl9H3V7o5YtULGUxykb9yAl2koSLPEH9u728QSrpa3PDF/j6T yObf0orpe0niqFVdr1Xnp4RQdtKZvMyBsbF11YVRvR2bKFZLXvj0BIS+O3nNico= =14WJ -----END PGP SIGNATURE----- ------enig2EFXTKLMIVFRRMGGPRLWV--