From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULMPj-0002zr-Sv for qemu-devel@nongnu.org; Thu, 28 Mar 2013 19:39:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULMPj-0001cg-4x for qemu-devel@nongnu.org; Thu, 28 Mar 2013 19:39:23 -0400 Received: from mail-ea0-x235.google.com ([2a00:1450:4013:c01::235]:51906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULMPi-0001cZ-Vd for qemu-devel@nongnu.org; Thu, 28 Mar 2013 19:39:23 -0400 Received: by mail-ea0-f181.google.com with SMTP id z10so24192ead.26 for ; Thu, 28 Mar 2013 16:39:22 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5154D4A6.9030808@redhat.com> Date: Fri, 29 Mar 2013 00:39:18 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1364507550-25093-1-git-send-email-aliguori@us.ibm.com> <1364507550-25093-4-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1364507550-25093-4-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 3/3] rbd: remove aio handler when no requests are pending List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , qemu-devel@nongnu.org, Mike Roth Il 28/03/2013 22:52, Anthony Liguori ha scritto: > This allows us to pass NULL for io_flush by removing the aio > event when no requests are pending. > > Signed-off-by: Anthony Liguori > --- > block/rbd.c | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) I'm not sure why this is an improvement? io_flush is basically the same as the io_can_read handler. Paolo