From: Paolo Bonzini <pbonzini@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Gleb Natapov <gleb@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>,
Orit Wasserman <owasserm@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Alexander Graf <agraf@suse.de>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Andrew Jones <drjones@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Sasha Levin <levinsasha928@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v16 5/6] pc_piix, pc_q35: export fw_cfg
Date: Fri, 29 Mar 2013 10:28:07 +0100 [thread overview]
Message-ID: <51555EA7.7080308@redhat.com> (raw)
In-Reply-To: <6cafd3eee5c1897db770a9d51c8c1de5e20a1c74.1364541739.git.hutao@cn.fujitsu.com>
Il 29/03/2013 09:16, Hu Tao ha scritto:
> diff --git a/hw/pc.h b/hw/pc.h
> index 8e1dd4c..d42b76b 100644
> --- a/hw/pc.h
> +++ b/hw/pc.h
> @@ -145,6 +145,12 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, int *piix_devfn,
> extern PCIDevice *piix4_dev;
> int piix4_init(PCIBus *bus, ISABus **isa_bus, int devfn);
>
> +/* pc_piix.c */
> +extern void *fw_cfg_piix;
> +
> +/* pc_q35.c */
> +extern void *fw_cfg_q35;
> +
> /* vga.c */
> enum vga_retrace_method {
> VGA_RETRACE_DUMB,
>
Hu, this is not what I suggested in the review...
Please do not ignore comments without answer, otherwise we'll just run
in circles.
Paolo
next prev parent reply other threads:[~2013-03-29 9:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 8:16 [Qemu-devel] [PATCH v16 0/6] Add pvpanic device to deal with guest panic event Hu Tao
2013-03-29 8:16 ` [Qemu-devel] [PATCH v16 1/6] add a new runstate: RUN_STATE_GUEST_PANICKED Hu Tao
2013-03-29 8:16 ` [Qemu-devel] [PATCH v16 2/6] add a new qevent: QEVENT_GUEST_PANICKED Hu Tao
2013-03-29 8:16 ` [Qemu-devel] [PATCH v16 3/6] introduce a new qom device to deal with panicked event Hu Tao
2013-03-29 8:16 ` [Qemu-devel] [PATCH v16 4/6] pvpanic: add document of pvpanic Hu Tao
2013-03-29 8:16 ` [Qemu-devel] [PATCH v16 5/6] pc_piix, pc_q35: export fw_cfg Hu Tao
2013-03-29 9:28 ` Paolo Bonzini [this message]
2013-04-01 8:47 ` Hu Tao
2013-03-29 8:16 ` [Qemu-devel] [PATCH v16 6/6] pvpanic: pass configurable ioport to seabios Hu Tao
2013-03-29 8:18 ` [Qemu-devel] [PATCH v16] Add pvpanic device driver Hu Tao
2013-03-29 9:28 ` Paolo Bonzini
2013-03-29 13:33 ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2013-03-29 13:49 ` Paolo Bonzini
2013-03-30 13:20 ` Kevin O'Connor
2013-03-30 15:36 ` Paolo Bonzini
2013-03-31 14:34 ` Gleb Natapov
2013-04-02 0:22 ` Kevin O'Connor
2013-04-02 9:07 ` Gleb Natapov
2013-04-10 0:37 ` Kevin O'Connor
2013-04-10 5:06 ` Hu Tao
2013-03-29 8:34 ` [Qemu-devel] [PATCH v16] pvpanic: " Hu Tao
2013-03-29 9:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51555EA7.7080308@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=drjones@redhat.com \
--cc=gleb@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=jan.kiszka@siemens.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lcapitulino@redhat.com \
--cc=levinsasha928@gmail.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=owasserm@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).