Re: [Qemu-devel] [Patch] fix /proc/self/maps output

Re: [Qemu-devel] [Patch] fix /proc/self/maps output

[Christophe Lyon]

Hi,
May I ping for this small patch?

Thanks,

Christophe


On 19 February 2013 17:28, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> Hi,
> Here is a small patch for the /proc/self/maps output (Linux user
> mode), which adds a space after the last number in the case where
> there is no filename to print. This matches what the kernel does, and
> is expected by libsanitizer.
>
> Christophe.

Re: [Qemu-devel] [Patch] fix /proc/self/maps output

[Peter Maydell]

On 29 March 2013 14:33, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> Hi,
> May I ping for this small patch?

Hi Christophe; I'm afraid the patch can't be applied because it's
missing a signed-off by. (Also if it was sent inline in the usual
format rather than as an attachment it would be easier to review.)

thanks
-- PMM

Re: [Qemu-devel] [Patch] fix /proc/self/maps output

[Christophe Lyon]

Hi,

Sorry I wasn't aware of such restrictions (I'm used to gcc/binutils
conventions), and my thunderbird does display my patch as if it were
inline :-)
So.... trying a cut-and-paste approach in gmail, for this one character patch:


/proc/self/maps: Add a space at end of line when there is no filename
to print, to conform to linux kernel format.

Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a148d9f..3b0ca86 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5016,7 +5016,7 @@ static int open_self_maps(void *cpu_env, int fd)
                     " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
                     h2g(min), h2g(max), flag_r, flag_w,
                     flag_x, flag_p, offset, dev_maj, dev_min, inode,
-                    path[0] ? "          " : "", path);
+                    path[0] ? "          " : " ", path);
         }
     }


On 29 March 2013 15:44, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 29 March 2013 14:33, Christophe Lyon <christophe.lyon@linaro.org> wrote:
>> Hi,
>> May I ping for this small patch?
>
> Hi Christophe; I'm afraid the patch can't be applied because it's
> missing a signed-off by. (Also if it was sent inline in the usual
> format rather than as an attachment it would be easier to review.)
>
> thanks
> -- PMM

Re: [Qemu-devel] [Patch] fix /proc/self/maps output

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

On 03/29/2013 09:13 AM, Christophe Lyon wrote:
> Hi,
> 
> Sorry I wasn't aware of such restrictions (I'm used to gcc/binutils
> conventions), and my thunderbird does display my patch as if it were
> inline :-)
> So.... trying a cut-and-paste approach in gmail, for this one character patch:

Still not ideal.  The commentary above should not be part of the final
commit message, so you should move it...

> 
> 
> /proc/self/maps: Add a space at end of line when there is no filename
> to print, to conform to linux kernel format.
> 
> Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>

...here, after a --- line that tells 'git am' where to stop reading
commit message.  'git send-email' is your friend.  Then whether or not
you use 'git send-email', it is always wise to test if your patch is
usable by first sending it to yourself, and seeing if 'git am' will do
the right thing with it.

http://wiki.qemu.org/Contribute/SubmitAPatch has more hints.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

Re: [Qemu-devel] [Patch] fix /proc/self/maps output

[Christophe Lyon]

Add a space at end of line when there is no filename to print, to
conform to linux kernel format.

Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>
---
 linux-user/syscall.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a148d9f..3b0ca86 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5016,7 +5016,7 @@ static int open_self_maps(void *cpu_env, int fd)
                     " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
                     h2g(min), h2g(max), flag_r, flag_w,
                     flag_x, flag_p, offset, dev_maj, dev_min, inode,
-                    path[0] ? "          " : "", path);
+                    path[0] ? "          " : " ", path);
         }
     }

--
1.7.10.4

On 29 March 2013 16:18, Eric Blake <eblake@redhat.com> wrote:
> On 03/29/2013 09:13 AM, Christophe Lyon wrote:
>> Hi,
>>
>> Sorry I wasn't aware of such restrictions (I'm used to gcc/binutils
>> conventions), and my thunderbird does display my patch as if it were
>> inline :-)
>> So.... trying a cut-and-paste approach in gmail, for this one character patch:
>
> Still not ideal.  The commentary above should not be part of the final
> commit message, so you should move it...
>
>>
>>
>> /proc/self/maps: Add a space at end of line when there is no filename
>> to print, to conform to linux kernel format.
>>
>> Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>
>
> ...here, after a --- line that tells 'git am' where to stop reading
> commit message.  'git send-email' is your friend.  Then whether or not
> you use 'git send-email', it is always wise to test if your patch is
> usable by first sending it to yourself, and seeing if 'git am' will do
> the right thing with it.
>
> http://wiki.qemu.org/Contribute/SubmitAPatch has more hints.
>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>

Re: [Qemu-devel] [Patch] fix /proc/self/maps output

[Peter Maydell]

On 29 March 2013 16:01, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> Add a space at end of line when there is no filename to print, to
> conform to linux kernel format.
>
> Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>


> ---
>  linux-user/syscall.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a148d9f..3b0ca86 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5016,7 +5016,7 @@ static int open_self_maps(void *cpu_env, int fd)
>                      " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
>                      h2g(min), h2g(max), flag_r, flag_w,
>                      flag_x, flag_p, offset, dev_maj, dev_min, inode,
> -                    path[0] ? "          " : "", path);
> +                    path[0] ? "          " : " ", path);
>          }
>      }
>
> --
> 1.7.10.4

Re: [Qemu-devel] [Patch] fix /proc/self/maps output

[H. Peter Anvin]

On 03/29/2013 09:01 AM, Christophe Lyon wrote:
> Add a space at end of line when there is no filename to print, to
> conform to linux kernel format.
> 
> Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>
> ---
>  linux-user/syscall.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a148d9f..3b0ca86 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5016,7 +5016,7 @@ static int open_self_maps(void *cpu_env, int fd)
>                      " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
>                      h2g(min), h2g(max), flag_r, flag_w,
>                      flag_x, flag_p, offset, dev_maj, dev_min, inode,
> -                    path[0] ? "          " : "", path);
> +                    path[0] ? "          " : " ", path);
>          }
>      }
> 

Please move the fixed space into the format.  Perhaps even use a %-123s
type format even...

	-hpa