From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42886)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ULdR0-00065P-Fz
	for qemu-devel@nongnu.org; Fri, 29 Mar 2013 13:49:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ULdQt-0000ii-NS
	for qemu-devel@nongnu.org; Fri, 29 Mar 2013 13:49:50 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:60549)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ULdQt-0000ay-Du
	for qemu-devel@nongnu.org; Fri, 29 Mar 2013 13:49:43 -0400
Message-ID: <5155D431.50701@weilnetz.de>
Date: Fri, 29 Mar 2013 18:49:37 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1202297355.13036709.1364209368956.JavaMail.root@redhat.com>
In-Reply-To: <1202297355.13036709.1364209368956.JavaMail.root@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 14/42] migration: prepare to access
 s->state outside critical sections
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@gmail.com>, Juan Quintela <quintela@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Orit Wasserman <owasserm@redhat.com>

Am 25.03.2013 12:02, schrieb Paolo Bonzini:
>
> ----- Messaggio originale -----
>> Da: "Gerd Hoffmann" <kraxel@redhat.com>
>> A: "Stefan Hajnoczi" <stefanha@gmail.com>
>> Cc: "Paolo Bonzini" <pbonzini@redhat.com>, "qemu-devel" <qemu-devel@no=
ngnu.org>, "Orit Wasserman"
>> <owasserm@redhat.com>, "Juan Quintela" <quintela@redhat.com>
>> Inviato: Luned=C3=AC, 25 marzo 2013 10:52:36
>> Oggetto: Re: [Qemu-devel] [PATCH 14/42] migration: prepare to access s=
->state outside critical sections
>>
>> Hi,
>>
>>> http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/56=
6/steps/compile/logs/stdio
>>>
>>> The latest RHEL6 mingw gcc is version 4.4 but this buildslave is
>>> RHEL6.1 so perhaps it's an older version that is missing the
>>> atomics builtins?
>> No, it's RHEL-6.4 actually, even though the name suggests otherwise
>> (was a bad idea to include the minor rev in the buildslave name ...).
> Can you check if this fixes it?
>
> diff --git a/configure b/configure
> index 46a7594..a324ca5 100755
> --- a/configure
> +++ b/configure
> @@ -931,9 +931,9 @@ case "$cpu" in
>             LDFLAGS=3D"-m64 $LDFLAGS"
>             ;;
>      i386)
> -           QEMU_CFLAGS=3D"-m32 $QEMU_CFLAGS"
> -           LDFLAGS=3D"-m32 $LDFLAGS"
> -           cc_i386=3D'$(CC) -m32'
> +           QEMU_CFLAGS=3D"-m32 -mcpu=3Di486 $QEMU_CFLAGS"
> +           LDFLAGS=3D"-m32 -mcpu=3Di486 $LDFLAGS"
> +           cc_i386=3D'$(CC) -m32 -mcpu=3Di486'
>             ;;
>      x86_64)
>             QEMU_CFLAGS=3D"-m64 $QEMU_CFLAGS"
>
> Paolo

Hi Stefan, hi Paolo,

cross compilation on Debian Squeeze shows the same error.

It is fixed by setting the correct cpu architecture (-march=3Di686).
As far as I know, gcc 4.4 defaults to -march=3Di386 which does
not support the atomic operations.

I have sent a patch today - please try it.

Regards,
Stefan