From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49122)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpa@zytor.com>) id 1ULhtz-000114-8Y
	for qemu-devel@nongnu.org; Fri, 29 Mar 2013 18:36:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpa@zytor.com>) id 1ULhtx-0007zW-81
	for qemu-devel@nongnu.org; Fri, 29 Mar 2013 18:36:03 -0400
Received: from terminus.zytor.com ([2001:1868:205::10]:42553
	helo=mail.zytor.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpa@zytor.com>) id 1ULhtw-0007uc-Ur
	for qemu-devel@nongnu.org; Fri, 29 Mar 2013 18:36:01 -0400
Message-ID: <5156173C.40609@zytor.com>
Date: Fri, 29 Mar 2013 15:35:40 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
MIME-Version: 1.0
References: <CAKdteOZ2NHm2eeH72UxahDrPSN5vu46J3ZsjLhFjMYjR=P2R2Q@mail.gmail.com>
	<CAKdteOb=pyX3rFU4V6XGAaCeG6rZTtzHcziyxHGNxmP42pvTRg@mail.gmail.com>
	<CAFEAcA-WSnmwnP0VOT8kiKA2c9D1EzPPY3v6h8bZpqtS5MvNMw@mail.gmail.com>
	<CAKdteOYy5J9oX3s6Z2GC2n5GQh4hDTBWw24kPTTe3i2P+qgmSA@mail.gmail.com>
	<5155B0D5.5080007@redhat.com>
	<CAKdteOY+vnGOFHQAsihxqO2YTzoexj3p7i4kTVbVro+8fqgxow@mail.gmail.com>
In-Reply-To: <CAKdteOY+vnGOFHQAsihxqO2YTzoexj3p7i4kTVbVro+8fqgxow@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Patch] fix /proc/self/maps output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On 03/29/2013 09:01 AM, Christophe Lyon wrote:
> Add a space at end of line when there is no filename to print, to
> conform to linux kernel format.
> 
> Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>
> ---
>  linux-user/syscall.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a148d9f..3b0ca86 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5016,7 +5016,7 @@ static int open_self_maps(void *cpu_env, int fd)
>                      " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
>                      h2g(min), h2g(max), flag_r, flag_w,
>                      flag_x, flag_p, offset, dev_maj, dev_min, inode,
> -                    path[0] ? "          " : "", path);
> +                    path[0] ? "          " : " ", path);
>          }
>      }
> 

Please move the fixed space into the format.  Perhaps even use a %-123s
type format even...

	-hpa