qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Andrew Jones <drjones@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Gleb Natapov <gleb@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Hu Tao <hutao@cn.fujitsu.com>,
	seabios@seabios.org, qemu-devel <qemu-devel@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	Blue Swirl <blauwirbel@gmail.com>,
	Orit Wasserman <owasserm@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	Sasha Levin <levinsasha928@gmail.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH v16] Add pvpanic device driver
Date: Sat, 30 Mar 2013 16:36:48 +0100	[thread overview]
Message-ID: <51570690.7030208@redhat.com> (raw)
In-Reply-To: <20130330132009.GA12564@morn.localdomain>

Il 30/03/2013 14:20, Kevin O'Connor ha scritto:
> On Fri, Mar 29, 2013 at 02:49:12PM +0100, Paolo Bonzini wrote:
>> Il 29/03/2013 14:33, Kevin O'Connor ha scritto:
>>> On Fri, Mar 29, 2013 at 04:18:44PM +0800, Hu Tao wrote:
>>>> pvpanic device is used to notify host(qemu) when guest panic happens.
>>>
>>> Thanks.  However, we're planning a move of ACPI tables from SeaBIOS to
>>> QEMU.  I think this should wait until after the move.
>>
>> The device should be in QEMU 1.5, and the SSDT probably will still be in
>> SeaBIOS by then (and might even be the last to move, since it's quite
>> complex and dynamic).  I don't think it is fair to block this patch on
>> those grounds...
> 
> What is the user visible impact of not having a panic device?

Management cannot restart or dump the guest after a panic, and cannot
log that a panic happened (as opposed to a random watchdog event).

> My main concern is that the patch creates a new fw_cfg channel between
> qemu and seabios thats sole purpose is to alter the OS visible ACPI
> tables.  These types of QEMU->SeaBIOS interfaces are fragile and are
> (in sum) quite complex.

Yes, this is true.

Paolo

  reply	other threads:[~2013-03-30 15:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29  8:16 [Qemu-devel] [PATCH v16 0/6] Add pvpanic device to deal with guest panic event Hu Tao
2013-03-29  8:16 ` [Qemu-devel] [PATCH v16 1/6] add a new runstate: RUN_STATE_GUEST_PANICKED Hu Tao
2013-03-29  8:16 ` [Qemu-devel] [PATCH v16 2/6] add a new qevent: QEVENT_GUEST_PANICKED Hu Tao
2013-03-29  8:16 ` [Qemu-devel] [PATCH v16 3/6] introduce a new qom device to deal with panicked event Hu Tao
2013-03-29  8:16 ` [Qemu-devel] [PATCH v16 4/6] pvpanic: add document of pvpanic Hu Tao
2013-03-29  8:16 ` [Qemu-devel] [PATCH v16 5/6] pc_piix, pc_q35: export fw_cfg Hu Tao
2013-03-29  9:28   ` Paolo Bonzini
2013-04-01  8:47     ` Hu Tao
2013-03-29  8:16 ` [Qemu-devel] [PATCH v16 6/6] pvpanic: pass configurable ioport to seabios Hu Tao
2013-03-29  8:18 ` [Qemu-devel] [PATCH v16] Add pvpanic device driver Hu Tao
2013-03-29  9:28   ` Paolo Bonzini
2013-03-29 13:33   ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2013-03-29 13:49     ` Paolo Bonzini
2013-03-30 13:20       ` Kevin O'Connor
2013-03-30 15:36         ` Paolo Bonzini [this message]
2013-03-31 14:34         ` Gleb Natapov
2013-04-02  0:22           ` Kevin O'Connor
2013-04-02  9:07             ` Gleb Natapov
2013-04-10  0:37               ` Kevin O'Connor
2013-04-10  5:06                 ` Hu Tao
2013-03-29  8:34 ` [Qemu-devel] [PATCH v16] pvpanic: " Hu Tao
2013-03-29  9:31   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51570690.7030208@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=borntraeger@de.ibm.com \
    --cc=drjones@redhat.com \
    --cc=gleb@redhat.com \
    --cc=hutao@cn.fujitsu.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kevin@koconnor.net \
    --cc=lcapitulino@redhat.com \
    --cc=levinsasha928@gmail.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=owasserm@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=seabios@seabios.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).