From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMTLz-0004pE-Bl for qemu-devel@nongnu.org; Sun, 31 Mar 2013 21:16:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMTLs-0007Ew-2q for qemu-devel@nongnu.org; Sun, 31 Mar 2013 21:16:07 -0400 Received: from mail-da0-x22b.google.com ([2607:f8b0:400e:c00::22b]:36059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMTLr-0007Eh-SW for qemu-devel@nongnu.org; Sun, 31 Mar 2013 21:16:00 -0400 Received: by mail-da0-f43.google.com with SMTP id u36so859241dak.30 for ; Sun, 31 Mar 2013 18:15:58 -0700 (PDT) Sender: Richard Henderson Message-ID: <5158DFCB.7040804@twiddle.net> Date: Sun, 31 Mar 2013 18:15:55 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1364776396-21581-1-git-send-email-aurelien@aurel32.net> In-Reply-To: <1364776396-21581-1-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] target-ppc: fix nego and subf*o instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org, Alexander Graf On 03/31/2013 05:33 PM, Aurelien Jarno wrote: > The overflow computation of nego and subf*o instructions has been broken > in commit ffe30937. Contrary to other targets, the instruction is subtract > from an not subtract on PowerPC. > > This patch fixes the issue by using the correct argument in the xor > computation. Thanks to Peter Maydell for the hint. > > With this change the PPC emulation passes the Gwenole Beauchesne > testsuite again. > > Cc: Alexander Graf > Cc: Richard Henderson > Signed-off-by: Aurelien Jarno > --- > target-ppc/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~