From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMh3o-000343-EG for qemu-devel@nongnu.org; Mon, 01 Apr 2013 11:54:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMh3m-0000FR-RM for qemu-devel@nongnu.org; Mon, 01 Apr 2013 11:54:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMh3m-0000Ey-GD for qemu-devel@nongnu.org; Mon, 01 Apr 2013 11:54:14 -0400 Message-ID: <5159AD5B.5020801@redhat.com> Date: Mon, 01 Apr 2013 09:52:59 -0600 From: Eric Blake MIME-Version: 1.0 References: <1364810491-21404-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1364810491-21404-4-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1364810491-21404-4-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2PSGIFRIAQAQVQBBQMBUL" Subject: Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2PSGIFRIAQAQVQBBQMBUL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/01/2013 04:01 AM, Wenchao Xia wrote: > Last operaton should be cancelled first. s/operaton/operation/ [I don't care enough about US vs. UK to say whether canceled or cancelled looks better] >=20 > Signed-off-by: Wenchao Xia > --- > blockdev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/blockdev.c b/blockdev.c > index 75416fb..a24d10e 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -954,7 +954,7 @@ void qmp_transaction(BlockdevActionList *dev_list, = Error **errp) > dev_entry =3D dev_entry->next; > =20 > states =3D g_malloc0(sizeof(BlkTransactionStates)); > - QSIMPLEQ_INSERT_TAIL(&snap_bdrv_states, states, entry); > + QSIMPLEQ_INSERT_HEAD(&snap_bdrv_states, states, entry); Is this a bug fix that for something that can be triggered by existing use of the 'transaction' command even without the additions you made in patches 1 and 2? If so, this probably ought to come first in the series, and you probably ought to consider enhancing the testsuite to show why it matters. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2PSGIFRIAQAQVQBBQMBUL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRWa1bAAoJEKeha0olJ0Nqg40H/1oit1z/sL3yrheB53QzPGIS JbqwfGN9xtp6UkNkFboyWGA4C6ZDMnzPKrA9il+2vk52as4gLv06QtuoY+WEm0NT A0BPMxxwjxzOxN3isy0G7mJKWgOE2nRNdWWoeDKqicoxuWzLo1izuP+56shrTAnW O+1cMfeVI6yZ4te7JQVTD/+gpExvB+XKEBx9LTOIChSJxawJdl0FVShbLq9/r3z3 WAFKzcGsHJhKjxG79gKXo0vzjUa5QvvEmKHSBEv7RiVrk6vFKsiA9IbBXGgp/WLa x6d1fdqm9ExMYlmWunVMlvgBfNzWjQvR8sjMHeOI52/267InMHhULTVUnz5tVhg= =CX/g -----END PGP SIGNATURE----- ------enig2PSGIFRIAQAQVQBBQMBUL--