From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMr3v-0008PC-GJ for qemu-devel@nongnu.org; Mon, 01 Apr 2013 22:35:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMr3t-0005Bp-LD for qemu-devel@nongnu.org; Mon, 01 Apr 2013 22:35:03 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:40839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMr3t-00057h-1y for qemu-devel@nongnu.org; Mon, 01 Apr 2013 22:35:01 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 2 Apr 2013 12:26:03 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id B9CB62CE8054 for ; Tue, 2 Apr 2013 13:34:40 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r322LVT751249368 for ; Tue, 2 Apr 2013 13:21:32 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r322Ydgn007287 for ; Tue, 2 Apr 2013 13:34:39 +1100 Message-ID: <515A43AB.3060309@linux.vnet.ibm.com> Date: Tue, 02 Apr 2013 10:34:19 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1364810491-21404-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1364810491-21404-4-git-send-email-xiawenc@linux.vnet.ibm.com> <5159AD5B.5020801@redhat.com> In-Reply-To: <5159AD5B.5020801@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, dietmar@proxmox.com, stefanha@gmail.com 于 2013-4-1 23:52, Eric Blake 写道: > On 04/01/2013 04:01 AM, Wenchao Xia wrote: >> Last operaton should be cancelled first. > > s/operaton/operation/ > > [I don't care enough about US vs. UK to say whether canceled or > cancelled looks better] > >> >> Signed-off-by: Wenchao Xia >> --- >> blockdev.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/blockdev.c b/blockdev.c >> index 75416fb..a24d10e 100644 >> --- a/blockdev.c >> +++ b/blockdev.c >> @@ -954,7 +954,7 @@ void qmp_transaction(BlockdevActionList *dev_list, Error **errp) >> dev_entry = dev_entry->next; >> >> states = g_malloc0(sizeof(BlkTransactionStates)); >> - QSIMPLEQ_INSERT_TAIL(&snap_bdrv_states, states, entry); >> + QSIMPLEQ_INSERT_HEAD(&snap_bdrv_states, states, entry); > > Is this a bug fix that for something that can be triggered by existing > use of the 'transaction' command even without the additions you made in > patches 1 and 2? If so, this probably ought to come first in the > series, and you probably ought to consider enhancing the testsuite to > show why it matters. > Originally it only support backing chain, it will have no difference about the sequence to delete it, but matters if other types of operation are added. -- Best Regards Wenchao Xia