From: Fabien Chouteau <chouteau@adacore.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450
Date: Tue, 02 Apr 2013 10:10:58 +0200 [thread overview]
Message-ID: <515A9292.3010801@adacore.com> (raw)
In-Reply-To: <80F6FC02-5D84-418D-8D47-79A95A2B6F9F@suse.de>
On 04/02/2013 10:56 AM, Alexander Graf wrote:
>
> On 02.04.2013, at 09:53, Fabien Chouteau wrote:
>
>> On 04/02/2013 10:09 AM, Alexander Graf wrote:
>>>
>>> What about the other users of hreset_vector? Can we just remove the variable altogether?
>>>
>>
>> For the CPUs that don't implement MSR[IP], the hreset_prefix is always
>> 0x00000000, so hreset_vector will be the reset address (i.e. 0xFFFFFFFC)
>>
>> I guess all this can be converted to a CPU feature flag, telling if
>> reset is an exception or not.
>
> Hrm, maybe. Not sure which way is cleaner.
>
> I'll apply your patch for now. It's certainly a step into the right direction.
>
OK, thanks,
--
Fabien Chouteau
next prev parent reply other threads:[~2013-04-02 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 12:06 [Qemu-devel] [PATCH 1/2] PPC: Remvove env->hreset_excp_prefix Fabien Chouteau
2013-03-29 12:06 ` [Qemu-devel] [PATCH 2/2] PPC: fix hreset_vector for 60x, 7x0, 7x5, G2, MPC8xx, MPC5xx, 7400 and 7450 Fabien Chouteau
2013-04-02 8:09 ` Alexander Graf
2013-04-02 7:53 ` Fabien Chouteau
2013-04-02 8:56 ` Alexander Graf
2013-04-02 8:10 ` Fabien Chouteau [this message]
2013-04-02 8:09 ` [Qemu-devel] [PATCH 1/2] PPC: Remvove env->hreset_excp_prefix Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515A9292.3010801@adacore.com \
--to=chouteau@adacore.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).