From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMy3Y-0001yB-0u for qemu-devel@nongnu.org; Tue, 02 Apr 2013 06:03:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMy3X-0007aK-11 for qemu-devel@nongnu.org; Tue, 02 Apr 2013 06:03:07 -0400 Message-ID: <515AACD7.6000507@redhat.com> Date: Tue, 02 Apr 2013 12:03:03 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1364835469-9317-1-git-send-email-brogers@suse.com> In-Reply-To: <1364835469-9317-1-git-send-email-brogers@suse.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] acpi: initialize s4_val used in s4 shutdown List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bruce Rogers Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org On 04/01/13 18:57, Bruce Rogers wrote: > While investigating why a 32 bit Windows 2003 guest wasn't able to > successfully perform a shutdown /h, it was discovered that commit > afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4 inadvertently dropped the > initialization of the s4_val used to handle s4 shutdown. > Initialize the value as before. > --- a/hw/acpi.c > +++ b/hw/acpi.c > @@ -474,6 +474,7 @@ static const MemoryRegionOps acpi_pm_cnt_ops = { > > void acpi_pm1_cnt_init(ACPIREGS *ar, MemoryRegion *parent) > { > + ar->pm1.cnt.s4_val = 2; The '2' used to come from PIIX4PMState->s4_val before commit afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4, see piix4_pm_properties, this behavior should be maintained IMHO. cheers, Gerd