From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49208)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UN6JB-0002dz-Gm
	for qemu-devel@nongnu.org; Tue, 02 Apr 2013 14:51:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UN6JA-0006I8-DE
	for qemu-devel@nongnu.org; Tue, 02 Apr 2013 14:51:49 -0400
Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:55960)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UN6JA-0006I0-6M
	for qemu-devel@nongnu.org; Tue, 02 Apr 2013 14:51:48 -0400
Received: by mail-ea0-f180.google.com with SMTP id d10so365585eaj.11
	for <qemu-devel@nongnu.org>; Tue, 02 Apr 2013 11:51:47 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <515B28BC.3020505@redhat.com>
Date: Tue, 02 Apr 2013 20:51:40 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1364913860-25159-1-git-send-email-pbonzini@redhat.com>
	<1364913860-25159-5-git-send-email-pbonzini@redhat.com>
	<CAFEAcA_NR78u9S_jn-vSsAHP=+W+Ci-8Mdt0Rcqz=Yrx=jC6nA@mail.gmail.com>
	<515B14BE.2060705@redhat.com>
	<CAFEAcA-Us3wP5fmNC8L2LyQ-TYx9__qyiVd8s=aYtZi81=+drA@mail.gmail.com>
In-Reply-To: <CAFEAcA-Us3wP5fmNC8L2LyQ-TYx9__qyiVd8s=aYtZi81=+drA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/5] configure: move common libraries to
	config-host.mak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

Il 02/04/2013 20:17, Peter Maydell ha scritto:

> This is because we seem to have lost the trailing "-lm -lz"; here's
> the tail end of the link command from a build on master for
> comparison:
> 
> translate-all.o xen-stub.o ../libqemuutil.a ../libqemustub.a  -lrt
> -pthread -lgthread-2.0 -lglib-2.0 -lrt -lpcre    -lutil -lbluetooth
> -lncurses -ltinfo    -lvdeplug -luuid -lpng12 -lz -lm    -laio -lfdt
> -lpixman-1    -lm -lz

I can fix this, but apparently upstream pixman doesn't support static linking:

$ pkg-config pixman-1 --libs
-lpixman-1  
$ pkg-config pixman-1 --libs --static
-lpixman-1  

which is why my distro vendor does not provide static libraries. :)

Here is the fix:

diff --git a/Makefile.target b/Makefile.target
index c8513f1..2636103 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -31,10 +31,6 @@ PROGS+=$(QEMU_PROGW)
 endif
 STPFILES=
 
-ifndef CONFIG_HAIKU
-LIBS+=-lm
-endif
-
 config-target.h: config-target.h-timestamp
 config-target.h-timestamp: config-target.mak
 
@@ -149,6 +145,10 @@ include $(SRC_PATH)/Makefile.objs
 all-obj-y = $(obj-y)
 all-obj-y += $(addprefix ../, $(common-obj-y))
 
+ifndef CONFIG_HAIKU
+LIBS+=-lm
+endif
+
 ifdef QEMU_PROGW
 # The linker builds a windows executable. Make also a console executable.
 $(QEMU_PROGW): $(all-obj-y) ../libqemuutil.a ../libqemustub.a

Paolo