From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNBlQ-0001zQ-64 for qemu-devel@nongnu.org; Tue, 02 Apr 2013 20:41:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNBlK-00043E-Lg for qemu-devel@nongnu.org; Tue, 02 Apr 2013 20:41:20 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:22837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNBlK-00042y-Fq for qemu-devel@nongnu.org; Tue, 02 Apr 2013 20:41:14 -0400 Message-ID: <515B7A95.6020800@oracle.com> Date: Tue, 02 Apr 2013 20:40:53 -0400 From: Sasha Levin MIME-Version: 1.0 References: <1362043352-56889-1-git-send-email-cornelia.huck@de.ibm.com> <1362043352-56889-4-git-send-email-cornelia.huck@de.ibm.com> In-Reply-To: <1362043352-56889-4-git-send-email-cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 3/6] KVM: Initialize irqfd from kvm_init(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Carsten Otte , KVM , Gleb Natapov , "Michael S. Tsirkin" , linux-s390 , Marcelo Tosatti , Heiko Carstens , Alexander Graf , qemu-devel , Christian Borntraeger , Martin Schwidefsky On 02/28/2013 04:22 AM, Cornelia Huck wrote: > Currently, eventfd introduces module_init/module_exit functions > to initialize/cleanup the irqfd workqueue. This only works, however, > if no other module_init/module_exit functions are built into the > same module. > > Let's just move the initialization and cleanup to kvm_init and kvm_exit. > This way, it is also clearer where kvm startup may fail. > > Signed-off-by: Cornelia Huck I'm seeing this during boot: [ 6.763302] ------------[ cut here ]------------ [ 6.763763] WARNING: at kernel/workqueue.c:4204 destroy_workqueue+0x1df/0x3d0() [ 6.764507] Modules linked in: [ 6.764792] Pid: 1, comm: swapper/0 Tainted: G W 3.9.0-rc5-next-20130402-sasha-00015-g3522ec5 #324 [ 6.765654] Call Trace: [ 6.765875] [] warn_slowpath_common+0x8b/0xc0 [ 6.766436] [] warn_slowpath_null+0x15/0x20 [ 6.766947] [] destroy_workqueue+0x1df/0x3d0 [ 6.768631] [] kvm_irqfd_exit+0x10/0x20 [ 6.770000] [] kvm_init+0x2ab/0x310 [ 6.770607] [] ? cpu_has_kvm_support+0x4d/0x4d [ 6.771241] [] vmx_init+0x1f4/0x437 [ 6.771709] [] ? cpu_has_kvm_support+0x4d/0x4d [ 6.772266] [] do_one_initcall+0xb2/0x1b0 [ 6.772995] [] kernel_init_freeable+0x15d/0x1ef [ 6.773857] [] ? loglevel+0x31/0x31 [ 6.774609] [] ? rest_init+0x140/0x140 [ 6.775551] [] kernel_init+0x9/0xf0 [ 6.776162] [] ret_from_fork+0x7c/0xb0 [ 6.776662] [] ? rest_init+0x140/0x140 [ 6.777241] ---[ end trace 10bba684ced4346a ]--- And I think it has something to do with this patch. Thanks, Sasha