From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41628)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1UNGMu-0008JL-Mg
	for qemu-devel@nongnu.org; Wed, 03 Apr 2013 01:36:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1UNGMq-0007iB-Uf
	for qemu-devel@nongnu.org; Wed, 03 Apr 2013 01:36:20 -0400
Received: from e28smtp03.in.ibm.com ([122.248.162.3]:48861)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1UNGMq-0007hm-6D
	for qemu-devel@nongnu.org; Wed, 03 Apr 2013 01:36:16 -0400
Received: from /spool/local
	by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Wed, 3 Apr 2013 11:02:34 +0530
Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61])
	by d28dlp02.in.ibm.com (Postfix) with ESMTP id AEFD23940058
	for <qemu-devel@nongnu.org>; Wed,  3 Apr 2013 11:06:08 +0530 (IST)
Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67])
	by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r335a4vZ3211602
	for <qemu-devel@nongnu.org>; Wed, 3 Apr 2013 11:06:05 +0530
Received: from d28av05.in.ibm.com (loopback [127.0.0.1])
	by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r335a7dG021920
	for <qemu-devel@nongnu.org>; Wed, 3 Apr 2013 16:36:07 +1100
Message-ID: <515BBFB2.2000406@linux.vnet.ibm.com>
Date: Wed, 03 Apr 2013 13:35:46 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1364810491-21404-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1364810491-21404-4-git-send-email-xiawenc@linux.vnet.ibm.com>
	<20130402135948.GK2341@dhcp-200-207.str.redhat.com>
In-Reply-To: <20130402135948.GK2341@dhcp-200-207.str.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in
	qmp_transaction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, dietmar@proxmox.com, stefanha@gmail.com

于 2013-4-2 21:59, Kevin Wolf 写道:
> Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben:
>>    Last operaton should be cancelled first.
>>
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>
> Should it? This commit message does little to convince me.
>
> Kevin
>
   I think so, if two request are "snapshot_blkdev ide0 newimage.qcow2",
"snapshot_blkdev_internal ide0 snap0", then in rollback delete of
snap0 would be wrong.

-- 
Best Regards

Wenchao Xia