qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] usb-tablet: Don't claim wakeup capability for USB-2 version
@ 2013-04-02 17:15 Hans de Goede
  2013-04-03  8:02 ` Gerd Hoffmann
  0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2013-04-02 17:15 UTC (permalink / raw)
  To: Gerd Hoffmann; +Cc: Hans de Goede, qemu-devel

Our ehci code does not implement wakeup support, so claiming support for
it with usb-tablet in USB-2 mode causes all tablet events to get lost.

http://bugzilla.redhat.com/show_bug.cgi?id=929068

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 hw/usb/dev-hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
index 9701048..317b474 100644
--- a/hw/usb/dev-hid.c
+++ b/hw/usb/dev-hid.c
@@ -236,7 +236,7 @@ static const USBDescDevice desc_device_tablet2 = {
             .bNumInterfaces        = 1,
             .bConfigurationValue   = 1,
             .iConfiguration        = STR_CONFIG_TABLET,
-            .bmAttributes          = 0xa0,
+            .bmAttributes          = 0x80,
             .bMaxPower             = 50,
             .nif = 1,
             .ifs = &desc_iface_tablet2,
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] usb-tablet: Don't claim wakeup capability for USB-2 version
  2013-04-02 17:15 [Qemu-devel] [PATCH] usb-tablet: Don't claim wakeup capability for USB-2 version Hans de Goede
@ 2013-04-03  8:02 ` Gerd Hoffmann
  0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2013-04-03  8:02 UTC (permalink / raw)
  To: Hans de Goede; +Cc: qemu-devel

On 04/02/13 19:15, Hans de Goede wrote:
> Our ehci code does not implement wakeup support, so claiming support for
> it with usb-tablet in USB-2 mode causes all tablet events to get lost.

Patch added to usb patch queue.

thanks,
  Gerd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-04-03  8:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-02 17:15 [Qemu-devel] [PATCH] usb-tablet: Don't claim wakeup capability for USB-2 version Hans de Goede
2013-04-03  8:02 ` Gerd Hoffmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).