From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNIik-00034a-G3 for qemu-devel@nongnu.org; Wed, 03 Apr 2013 04:07:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNIij-0008Lk-8d for qemu-devel@nongnu.org; Wed, 03 Apr 2013 04:07:02 -0400 Message-ID: <515BE321.6080208@redhat.com> Date: Wed, 03 Apr 2013 10:06:57 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1364928100-487-1-git-send-email-brogers@suse.com> In-Reply-To: <1364928100-487-1-git-send-email-brogers@suse.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v2 PATCH] acpi: initialize s4_val used in s4 shutdown List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bruce Rogers Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org On 04/02/13 20:41, Bruce Rogers wrote: > While investigating why a 32 bit Windows 2003 guest wasn't able to > successfully perform a shutdown /h, it was discovered that commit > afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4 inadvertently dropped the > initialization of the s4_val used to handle s4 shutdown. > Initialize the value as before. Looks good to me now. Reviewed-by: Gerd Hoffmann cheers, Gerd