From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNIir-0003A5-Nu for qemu-devel@nongnu.org; Wed, 03 Apr 2013 04:07:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNIiq-0008OX-Ky for qemu-devel@nongnu.org; Wed, 03 Apr 2013 04:07:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNIiq-0008OH-CE for qemu-devel@nongnu.org; Wed, 03 Apr 2013 04:07:08 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r33872hY018164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Apr 2013 04:07:03 -0400 Message-ID: <515BE38E.8050505@redhat.com> Date: Wed, 03 Apr 2013 11:08:46 +0300 From: Orit Wasserman MIME-Version: 1.0 References: <1364402192-18169-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1364402192-18169-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] migration: followups for writev patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, quintela@redhat.com On 03/27/2013 06:36 PM, Paolo Bonzini wrote: > This series fixes a few small problems in Orit's writev patches: > > 1) socket_put_buffer is not needed anymore and can be dropped (patch 1); > > 2) sendmsg could do a partial write even for a blocking socket, in > case it is interrupted by a signal. This should not happen for > migration, but it is relatively easy to fix in iov_send_recv (patches > 2 to 5); > > 3) recent libvirt will always use fd migration, and thus will not > benefit from the writev speedups. fd migration also uses FILE*, which > incurs an extra copy. Patch 6 fixes both issues. > > Thanks, > > Paolo > > Paolo Bonzini (6): > qemu-file: drop socket_put_buffer > iov: reorganize iov_send_recv, part 1 > iov: reorganize iov_send_recv, part 2 > iov: reorganize iov_send_recv, part 3 > iov: handle partial writes from sendmsg and recvmsg > qemu-file: do not use stdio for qemu_fdopen > > savevm.c | 113 ++++++++++++++++++++++++++++++++++++++++++++++++------------- > util/iov.c | 104 ++++++++++++++++++++++++++++++++------------------------ > 2 files changed, 148 insertions(+), 69 deletions(-) > Series Reviewed-by: Orit Wasserman