From: Paolo Bonzini <pbonzini@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
stefanha@gmail.com, qemu-devel@nongnu.org, dietmar@proxmox.com
Subject: Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable
Date: Wed, 03 Apr 2013 11:17:09 +0200 [thread overview]
Message-ID: <515BF395.6010101@redhat.com> (raw)
In-Reply-To: <515BF023.8080701@linux.vnet.ibm.com>
Il 03/04/2013 11:02, Wenchao Xia ha scritto:
>>
> Sorry I haven't state it clearly. What about bdrv_snapshot_create()
> operation? If it need to be rolled back, I think bdrv_snapshot_delete()
> will get called and it may fail. But in most case if
> bdrv_snapshot_create() succeed before, the bdrv_snapshot_delete should
> succeed also, so if fail there may be unexpected error below, could
> assert be used for this?
No. Transactionable means that commit and rollback cannot fail.
For bdrv_snapshot_create() it is the same as for bdrv_snapshot_delete()
(the overview I wrote was for qcow2_write_snapshots, which is the common
part of bdrv_snapshot_create() and bdrv_snapshot_delete()).
Please do one thing at a time. Split the series in multiple pieces if
possible. Otherwise you will just fail, and you will have wasted a lot
of your and other people's time.
Paolo
next prev parent reply other threads:[~2013-04-03 9:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 10:01 [Qemu-devel] [PATCH 0/3] block: make qmp_transaction extendable Wenchao Xia
2013-04-01 10:01 ` [Qemu-devel] [PATCH 1/3] block: add function deappend() Wenchao Xia
2013-04-01 10:01 ` [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable Wenchao Xia
2013-04-02 13:55 ` Kevin Wolf
2013-04-03 5:51 ` Wenchao Xia
2013-04-03 7:21 ` Paolo Bonzini
2013-04-03 9:02 ` Wenchao Xia
2013-04-03 9:17 ` Paolo Bonzini [this message]
2013-04-03 9:22 ` Kevin Wolf
2013-04-03 10:33 ` Wenchao Xia
2013-04-17 14:42 ` Stefan Hajnoczi
2013-04-18 3:00 ` Wenchao Xia
2013-04-18 6:35 ` Stefan Hajnoczi
2013-04-01 10:01 ` [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction Wenchao Xia
2013-04-01 15:52 ` Eric Blake
2013-04-02 2:34 ` Wenchao Xia
2013-04-02 13:59 ` Kevin Wolf
2013-04-03 5:35 ` Wenchao Xia
2013-04-03 9:03 ` Kevin Wolf
2013-04-03 10:35 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515BF395.6010101@redhat.com \
--to=pbonzini@redhat.com \
--cc=dietmar@proxmox.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).