From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNKKF-0000d6-Fv for qemu-devel@nongnu.org; Wed, 03 Apr 2013 05:49:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNKKE-0005yn-Ap for qemu-devel@nongnu.org; Wed, 03 Apr 2013 05:49:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNKKE-0005yg-3a for qemu-devel@nongnu.org; Wed, 03 Apr 2013 05:49:50 -0400 Message-ID: <515BFB30.4070603@redhat.com> Date: Wed, 03 Apr 2013 11:49:36 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1364574522-4093-1-git-send-email-alexandru.damian@intel.com> In-Reply-To: <1364574522-4093-1-git-send-email-alexandru.damian@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vmware_vga: do not cache depth and bypp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex DAMIAN Cc: blauwirbel@gmail.com, pbonzini@redhat.com, Jan Kiszka , qemu-devel@nongnu.org On 03/29/13 17:28, Alex DAMIAN wrote: > From: Alexandru DAMIAN > > Do not cache depth and bypp information in the device state. > > This resolves a bug where Xorg video-vmare driver refuses > to start up because the depth value read is the one cached from the > device start (default 32 from ui/console.c) and it is not consistent > with the graphical console depth, which may be different from > the default depth. Does it actually work? /me posted a simliar patch and according to Jan (Cc'ed) it doesn't fix the issue. > @@ -1113,7 +1111,6 @@ static const VMStateDescription vmstate_vmware_vga_internal = { > .minimum_version_id_old = 0, > .post_load = vmsvga_post_load, > .fields = (VMStateField[]) { > - VMSTATE_INT32_EQUAL(depth, struct vmsvga_state_s), This breaks live migration. cheers, Gerd