From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNL6G-0000Us-Ji for qemu-devel@nongnu.org; Wed, 03 Apr 2013 06:39:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNL6A-0006WE-1p for qemu-devel@nongnu.org; Wed, 03 Apr 2013 06:39:28 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:46876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNL69-0006VX-UU for qemu-devel@nongnu.org; Wed, 03 Apr 2013 06:39:21 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Apr 2013 06:39:20 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id D1673C9001D for ; Wed, 3 Apr 2013 06:39:16 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r33AdGoA073060 for ; Wed, 3 Apr 2013 06:39:16 -0400 Received: from d01av05.pok.ibm.com (loopback [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r33AdGxP018351 for ; Wed, 3 Apr 2013 06:39:16 -0400 Message-ID: <515C06D4.9060104@linux.vnet.ibm.com> Date: Wed, 03 Apr 2013 06:39:16 -0400 From: Stefan Berger MIME-Version: 1.0 References: <1364933691-21197-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1364933691-21197-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tpm: Fix several compiler warnings (redefined data types) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Anthony Liguori , qemu-devel@nongnu.org On 04/02/2013 04:14 PM, Stefan Weil wrote: What compiler and options did you use? > Signed-off-by: Stefan Weil Reviewed-by: Stefan Berger > --- > tpm/tpm_int.h | 9 ++------- > tpm/tpm_tis.h | 4 ++-- > 2 files changed, 4 insertions(+), 9 deletions(-) > > diff --git a/tpm/tpm_int.h b/tpm/tpm_int.h > index b4787ad..340bfd5 100644 > --- a/tpm/tpm_int.h > +++ b/tpm/tpm_int.h > @@ -15,11 +15,8 @@ > #include "exec/memory.h" > #include "tpm/tpm_tis.h" > > -struct TPMDriverOps; > -typedef struct TPMDriverOps TPMDriverOps; > - > /* overall state of the TPM interface */ > -typedef struct TPMState { > +struct TPMState { > ISADevice busdev; > MemoryRegion mmio; > > @@ -32,12 +29,10 @@ typedef struct TPMState { > > char *backend; > TPMBackend *be_driver; > -} TPMState; > +}; > > #define TPM(obj) OBJECT_CHECK(TPMState, (obj), TYPE_TPM_TIS) > > -typedef void (TPMRecvDataCB)(TPMState *, uint8_t locty); > - > struct TPMDriverOps { > enum TpmType type; > /* get a descriptive text of the backend to display to the user */ > diff --git a/tpm/tpm_tis.h b/tpm/tpm_tis.h > index 0c8df80..7f216e5 100644 > --- a/tpm/tpm_tis.h > +++ b/tpm/tpm_tis.h > @@ -35,10 +35,10 @@ > #define TYPE_TPM_TIS "tpm-tis" > > > -typedef struct TPMSizedBuffer { > +struct TPMSizedBuffer { > uint32_t size; > uint8_t *buffer; > -} TPMSizedBuffer; > +}; > > typedef enum { > TPM_TIS_STATE_IDLE = 0,