From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNMDy-0000R8-Vu for qemu-devel@nongnu.org; Wed, 03 Apr 2013 07:51:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNMDx-0006cL-OC for qemu-devel@nongnu.org; Wed, 03 Apr 2013 07:51:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNMDx-0006cF-Gl for qemu-devel@nongnu.org; Wed, 03 Apr 2013 07:51:29 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r33BpSfY019019 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Apr 2013 07:51:28 -0400 Message-ID: <515C17BB.3010706@redhat.com> Date: Wed, 03 Apr 2013 13:51:23 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1364914749-11141-1-git-send-email-pbonzini@redhat.com> <1364914749-11141-21-git-send-email-pbonzini@redhat.com> <20130403104219.GA18803@redhat.com> <20130403105151.GA18936@redhat.com> In-Reply-To: <20130403105151.GA18936@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 20/35] hw: move ISA bridges and devices to hw/isa/, configure with default-configs/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org Il 03/04/2013 12:51, Michael S. Tsirkin ha scritto: >>> > > default-configs/i386-softmmu.mak | 4 ++++ >>> > > default-configs/x86_64-softmmu.mak | 4 ++++ >>> > > hw/i386/Makefile.objs | 7 ++----- >>> > > hw/isa/Makefile.objs | 6 ++++++ >>> > > hw/{ => isa}/debugexit.c | 0 >>> > > hw/{ => isa}/lpc_ich9.c | 0 >>> > > hw/{ => isa}/pc-testdev.c | 0 >> > >> > This at least seems wrong. debug devices should be in >> > hw/debug or hw/test. And it does not matter that LPC >> > uses some ISA ports. It's a chipset device. >> > So hw/chipset or something ... >> > > Maybe hw/system/ or hw/bridge/ > > lpc_ich9.c is an ISA bridge, hence it is in hw/isa. debugexit and pc-testdev are exceptions. I didn't really have a better place. Paolo