From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNMIC-0002x8-Ly for qemu-devel@nongnu.org; Wed, 03 Apr 2013 07:55:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNMIB-0008IJ-Bw for qemu-devel@nongnu.org; Wed, 03 Apr 2013 07:55:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNMIB-0008ID-3J for qemu-devel@nongnu.org; Wed, 03 Apr 2013 07:55:51 -0400 Message-ID: <515C18BF.40105@redhat.com> Date: Wed, 03 Apr 2013 13:55:43 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1364914749-11141-1-git-send-email-pbonzini@redhat.com> <20130403104951.GD18803@redhat.com> In-Reply-To: <20130403104951.GD18803@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Peter Maydell , Igor Mammedov , qemu-devel@nongnu.org, Andreas Faerber Il 03/04/2013 12:49, Michael S. Tsirkin ha scritto: > The idea to sort devices by function makes sense to be. > But ISA and PCI here are wrong, they try to sort > things by connection. Almost all ISA and PCI devices are in their logical places. You could find the outliers immediately because they are so few. :) I can certainly put them in hw/misc if you prefer, but hw/vfio_pci.c makes more sense to me as hw/pci/vfio.c than as hw/misc/vfio.c. Paolo