qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Damian, Alexandru" <alexandru.damian@intel.com>
Cc: blauwirbel@gmail.com, pbonzini@redhat.com,
	Jan Kiszka <jan.kiszka@web.de>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vmware_vga: do not cache depth and bypp
Date: Wed, 03 Apr 2013 13:59:31 +0200	[thread overview]
Message-ID: <515C19A3.8080905@redhat.com> (raw)
In-Reply-To: <CAJ2CSBvCx+b4+dqdicqyB3QGs1XO+HEirpaq-3PWwunfaGhbjQ@mail.gmail.com>

On 04/03/13 12:13, Damian, Alexandru wrote:
> It fixes my test case, that is starting up with 32 bits depth console and
> then switching to 16 bits depth -
> since the depth is cached, xf64-video-vmware gets 565-weight but 32 bit
> depth, and refuses to start.

Jan's case is booting with vesafb @ 16bpp, then start x (then get
inconsistent values too).

> There is another similar bug I'm tackling now - when the window resizes,
> qemu_console_resize() creates
> a new console with a hardcoded 32-bit depth, instead of current depth,
> which breaks the display.

vmware vga should not use qemu_console_resize in the first place ...

cheers,
  Gerd

      parent reply	other threads:[~2013-04-03 11:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29 16:28 [Qemu-devel] [PATCH] vmware_vga: do not cache depth and bypp Alex DAMIAN
2013-04-03  9:49 ` Gerd Hoffmann
2013-04-03 10:13   ` Damian, Alexandru
2013-04-03 10:48     ` Damian, Alexandru
2013-04-03 11:59     ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515C19A3.8080905@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alexandru.damian@intel.com \
    --cc=blauwirbel@gmail.com \
    --cc=jan.kiszka@web.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).