From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNMLy-0004be-Q3 for qemu-devel@nongnu.org; Wed, 03 Apr 2013 07:59:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNMLs-0001As-Ny for qemu-devel@nongnu.org; Wed, 03 Apr 2013 07:59:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNMLs-0001Ab-G0 for qemu-devel@nongnu.org; Wed, 03 Apr 2013 07:59:40 -0400 Message-ID: <515C19A3.8080905@redhat.com> Date: Wed, 03 Apr 2013 13:59:31 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1364574522-4093-1-git-send-email-alexandru.damian@intel.com> <515BFB30.4070603@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vmware_vga: do not cache depth and bypp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Damian, Alexandru" Cc: blauwirbel@gmail.com, pbonzini@redhat.com, Jan Kiszka , qemu-devel@nongnu.org On 04/03/13 12:13, Damian, Alexandru wrote: > It fixes my test case, that is starting up with 32 bits depth console and > then switching to 16 bits depth - > since the depth is cached, xf64-video-vmware gets 565-weight but 32 bit > depth, and refuses to start. Jan's case is booting with vesafb @ 16bpp, then start x (then get inconsistent values too). > There is another similar bug I'm tackling now - when the window resizes, > qemu_console_resize() creates > a new console with a hardcoded 32-bit depth, instead of current depth, > which breaks the display. vmware vga should not use qemu_console_resize in the first place ... cheers, Gerd