From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNcwU-0007kD-T1 for qemu-devel@nongnu.org; Thu, 04 Apr 2013 01:42:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNcwT-0001Kc-MC for qemu-devel@nongnu.org; Thu, 04 Apr 2013 01:42:34 -0400 Received: from ssl.dlhnet.de ([91.198.192.8]:55559 helo=ssl.dlh.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNcwT-0001KS-GL for qemu-devel@nongnu.org; Thu, 04 Apr 2013 01:42:33 -0400 Received: from localhost (localhost [127.0.0.1]) by ssl.dlh.net (Postfix) with ESMTP id 6C02414794E for ; Thu, 4 Apr 2013 07:42:32 +0200 (CEST) Received: from ssl.dlh.net ([127.0.0.1]) by localhost (ssl.dlh.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FBzOT4LPCJ74 for ; Thu, 4 Apr 2013 07:42:31 +0200 (CEST) Received: from [172.21.12.60] (unknown [82.141.1.226]) by ssl.dlh.net (Postfix) with ESMTPSA id D59F2143998 for ; Thu, 4 Apr 2013 07:42:31 +0200 (CEST) Message-ID: <515D12DA.8020308@dlhnet.de> Date: Thu, 04 Apr 2013 07:42:50 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1363701863-13004-1-git-send-email-kraxel@redhat.com> <1ba01d1f676845e458dba25a096bd1fa.squirrel@ssl.dlhnet.de> <515C2222.8080804@redhat.com> <20130403093625.5bd51f0d@redhat.com> In-Reply-To: <20130403093625.5bd51f0d@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] fix monitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 03.04.2013 15:36, Luiz Capitulino wrote: > On Wed, 03 Apr 2013 14:35:46 +0200 > Gerd Hoffmann wrote: > >> On 04/03/13 14:17, Peter Lieven wrote: >>> Hi Gerd, >>> >>> I today saw this assert when live migrating a VM. Is this related? The >>> below patch was already applied. >>> >>> qemu-1.4.5: /usr/src/qemu-1.4.5/monitor.c:297: monitor_puts: Assertion >>> `mon->outbuf_index < sizeof(mon->outbuf) - 1' failed. >> Probably, patches (from luiz) are on the list to make the monitor buffer >> size dynamic, they should fix it. > Yes. > > Peter, can you please try my series and report if it really fixes the > assertion for you? > > http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg00369.html > I will do, but the assertion was not as easy triggerable for me as typing '?'. We run some tests today with the patches applied and I will let you know if there where any further assertions. Peter