* [Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction
@ 2013-03-13 15:58 Alon Levy
2013-03-13 16:16 ` Hans de Goede
2013-04-04 8:21 ` Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Alon Levy @ 2013-03-13 15:58 UTC (permalink / raw)
To: qemu-devel; +Cc: kraxel
No change for 64 bit arches, but for 32 bit previously we zeroed half
the surfaces cmd array, instead of all of it.
Signed-off-by: Alon Levy <alevy@redhat.com>
---
hw/qxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index ef69348..4cbab45 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -226,7 +226,7 @@ static void qxl_spice_destroy_surfaces_complete(PCIQXLDevice *qxl)
trace_qxl_spice_destroy_surfaces_complete(qxl->id);
qemu_mutex_lock(&qxl->track_lock);
memset(qxl->guest_surfaces.cmds, 0,
- sizeof(qxl->guest_surfaces.cmds) * qxl->ssd.num_surfaces);
+ sizeof(qxl->guest_surfaces.cmds[0]) * qxl->ssd.num_surfaces);
qxl->guest_surfaces.count = 0;
qemu_mutex_unlock(&qxl->track_lock);
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction
2013-03-13 15:58 [Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction Alon Levy
@ 2013-03-13 16:16 ` Hans de Goede
2013-04-04 8:21 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2013-03-13 16:16 UTC (permalink / raw)
To: Alon Levy; +Cc: qemu-devel, kraxel
Looks good,
Acked-by: Hans de Goede <hdegoede@redhat.com>
On 03/13/2013 04:58 PM, Alon Levy wrote:
> No change for 64 bit arches, but for 32 bit previously we zeroed half
> the surfaces cmd array, instead of all of it.
>
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
> hw/qxl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/qxl.c b/hw/qxl.c
> index ef69348..4cbab45 100644
> --- a/hw/qxl.c
> +++ b/hw/qxl.c
> @@ -226,7 +226,7 @@ static void qxl_spice_destroy_surfaces_complete(PCIQXLDevice *qxl)
> trace_qxl_spice_destroy_surfaces_complete(qxl->id);
> qemu_mutex_lock(&qxl->track_lock);
> memset(qxl->guest_surfaces.cmds, 0,
> - sizeof(qxl->guest_surfaces.cmds) * qxl->ssd.num_surfaces);
> + sizeof(qxl->guest_surfaces.cmds[0]) * qxl->ssd.num_surfaces);
> qxl->guest_surfaces.count = 0;
> qemu_mutex_unlock(&qxl->track_lock);
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction
2013-03-13 15:58 [Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction Alon Levy
2013-03-13 16:16 ` Hans de Goede
@ 2013-04-04 8:21 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2013-04-04 8:21 UTC (permalink / raw)
To: Alon Levy; +Cc: qemu-devel
On 03/13/13 16:58, Alon Levy wrote:
> No change for 64 bit arches, but for 32 bit previously we zeroed half
> the surfaces cmd array, instead of all of it.
Patch added to spice patch queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-04 8:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-13 15:58 [Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction Alon Levy
2013-03-13 16:16 ` Hans de Goede
2013-04-04 8:21 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).