From: "Andreas Färber" <afaerber@suse.de>
To: Rabin Vincent <rabin@rab.in>, Jens Freimann <jfrei@linux.vnet.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCHv2 0/6] ARM dump-guest-memory support
Date: Thu, 04 Apr 2013 10:52:37 +0200 [thread overview]
Message-ID: <515D3F55.7080205@suse.de> (raw)
In-Reply-To: <CAH+eYFD8ZXctLQ2-X5MX3EudWEGhKTsSH+kxWOFjZhqyXcdF2Q@mail.gmail.com>
Am 29.03.2013 09:36, schrieb Rabin Vincent:
> 2013/3/25 Andreas Färber <afaerber@suse.de>
>> This still does not address the architectural issue that I brought up.
>
> I guess you mean the CPUArchState stuff? AFAICS Wen Congyang (the
> author of the dump code) had some answers/questions for you:
>
> http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00382.html
> http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00384.html
Yes, that is what I'm referring to, and I don't see answers to my
questions...
If as I understand we are talking about a property that depends solely
on the target CPU then it should be implemented on CPUClass level (which
is the one above ARMCPU, S390CPU etc.) and not require changes to
configure at all. CPUArchState is by contrast a per-target type.
qom/cpu.c would implement the dummy versions and in your case
target-arm/cpu.c (in Jens' case target-s390x/cpu.c) should override that
behavior by setting cc->whatever to a static function that actually
implements the functionality. I would supply you with a patch for that
myself, but I am rather busy with downstream ATM and Igor is poking me
for x86 CPU review, so if either of you or Wen Congyang could fix that
design flaw before making it worse I would appreciate that!
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-04-04 8:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 17:27 [Qemu-devel] [PATCHv2 0/6] ARM dump-guest-memory support Rabin Vincent
2013-03-24 17:27 ` [Qemu-devel] [PATCHv2 1/6] dump: create writable files Rabin Vincent
2013-04-04 9:42 ` Paolo Bonzini
2013-03-24 17:27 ` [Qemu-devel] [PATCHv2 2/6] dump: extract out note helper Rabin Vincent
2013-03-24 17:27 ` [Qemu-devel] [PATCHv2 3/6] dump: extract out get note size function Rabin Vincent
2013-03-24 17:27 ` [Qemu-devel] [PATCHv2 4/6] dump: fix up memory mapping dependencies / stub Rabin Vincent
2013-04-04 9:43 ` Paolo Bonzini
2013-03-24 17:27 ` [Qemu-devel] [PATCHv2 5/6] target-arm: add dump-guest-memory support Rabin Vincent
2013-03-24 18:34 ` Peter Maydell
2013-03-24 19:26 ` Rabin Vincent
2013-03-24 20:39 ` Peter Maydell
2013-04-04 9:47 ` Paolo Bonzini
2013-04-04 9:49 ` Peter Maydell
2013-03-24 17:27 ` [Qemu-devel] [PATCHv2 6/6] dump: fix memory region handling Rabin Vincent
2013-03-24 18:36 ` Peter Maydell
2013-03-24 19:35 ` Rabin Vincent
2013-03-24 20:18 ` Peter Maydell
2013-03-25 11:49 ` [Qemu-devel] [PATCHv2 0/6] ARM dump-guest-memory support Andreas Färber
2013-03-29 8:36 ` Rabin Vincent
2013-04-04 8:52 ` Andreas Färber [this message]
2013-04-09 12:09 ` [Qemu-devel] [RFC] make write_elf_xx functions part of CPUClass, use CPUState Jens Freimann
2013-04-09 13:15 ` Andreas Färber
2013-04-19 14:45 ` [Qemu-devel] [PATCH 0/2] qom: make cpu_write_elfXX_ functions part of CPUClass Jens Freimann
2013-04-19 14:45 ` [Qemu-devel] [PATCH 1/2] qom: Convert cpu_write_elfXX_note functions to CPUState Jens Freimann
2013-04-19 14:45 ` [Qemu-devel] [PATCH 2/2] i386: use CPUClass->write_elf* functions Jens Freimann
2013-04-29 14:21 ` [Qemu-devel] [PATCH 0/2] qom: make cpu_write_elfXX_ functions part of CPUClass Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515D3F55.7080205@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=jfrei@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).