From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNkmE-0007fL-80 for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:04:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNkm6-0000oA-Hq for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:04:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNkm6-0000lw-2v for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:04:22 -0400 Message-ID: <515D8857.1090204@redhat.com> Date: Thu, 04 Apr 2013 16:04:07 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1364985128-23772-1-git-send-email-pbonzini@redhat.com> <1364985128-23772-6-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 05/10] elfload: use abi_int/uint instead of target_int/uint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, aurelien@aurel32.net Il 04/04/2013 15:56, Peter Maydell ha scritto: >> > #define TARGET_LONG_BITS 32 >> > +#define ABI_INT_ALIGNMENT 2 >> > >> > #define CPUArchState struct CPUM68KState > I think this define should go in an include file in > linux-user/m68k/ -- it's ABI specific and we should > be aiming to isolate ABI specific info in linux-user/ > rather than having it leaking into target-* and thus > into the system emulation code. > > Otherwise patch looks good. That would create 10 empty files, and two files between one and three lines of code. I would just put those in include/exec/user/abitypes.h. WDYT? Paolo