From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43306)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UNksy-0005If-Hb
	for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:11:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UNkst-0003s8-Ts
	for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:11:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65206)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UNkst-0003qT-MJ
	for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:11:23 -0400
Message-ID: <515D89F5.5000504@redhat.com>
Date: Thu, 04 Apr 2013 16:11:01 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1364985128-23772-1-git-send-email-pbonzini@redhat.com>
	<1364985128-23772-7-git-send-email-pbonzini@redhat.com>
	<CAFEAcA-me-4hL_JG8w2G1-L8s1C8Z0ORwz4tMQxG9pVCRkfW5A@mail.gmail.com>
In-Reply-To: <CAFEAcA-me-4hL_JG8w2G1-L8s1C8Z0ORwz4tMQxG9pVCRkfW5A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 06/10] elfload: only give abi_long/ulong
 the alignment specified by the target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: pmaydell@linaro.org, qemu-devel@nongnu.org, aurelien@aurel32.net

Il 04/04/2013 16:09, Peter Maydell ha scritto:
> Agreed in principle, but you seem to have missed some structs
> which use target_ulong currently and which presumably should
> use abi_ulong instead, eg all the target_ucontext etc structs
> in linux-user/signal.c

Right.

> Also linux-user/elfload.c:symfind() is casting a pointer to
> target_ulong* and dereferencing it, and that might now cause
> an alignment fault on some host CPUs if the host CPU alignment
> requirements are stricter than the guest's.

I had seen this, but it is only used with bsearch and safe:

static const char *lookup_symbolxx(struct syminfo *s, target_ulong orig_addr)
{
#if ELF_CLASS == ELFCLASS32
    struct elf_sym *syms = s->disas_symtab.elf32;
#else
    struct elf_sym *syms = s->disas_symtab.elf64;
#endif

    // binary search
    struct elf_sym *sym;

    sym = bsearch(&orig_addr, syms, s->disas_num_syms, sizeof(*syms), symfind);
    ...
}

Paolo