From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48437)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UNl9Z-0002uK-Aa
	for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:28:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UNl9U-0001sI-OQ
	for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:28:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22949)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UNl9U-0001ry-GT
	for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:28:32 -0400
Message-ID: <515D8DF9.4040909@redhat.com>
Date: Thu, 04 Apr 2013 16:28:09 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1364985128-23772-1-git-send-email-pbonzini@redhat.com>
	<1364985128-23772-6-git-send-email-pbonzini@redhat.com>
	<CAFEAcA85THVKLtynoZU3fBhgyXN2-gMHg2CDsvE__Cj9ZFgz2g@mail.gmail.com>
	<515D8857.1090204@redhat.com>
	<CAFEAcA8PQNxbGvahJaKBJL+Jdc1OBO0wzpM-6z==9rEm3nQH8Q@mail.gmail.com>
In-Reply-To: <CAFEAcA8PQNxbGvahJaKBJL+Jdc1OBO0wzpM-6z==9rEm3nQH8Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 05/10] elfload: use abi_int/uint instead
 of target_int/uint
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org, aurelien@aurel32.net

Il 04/04/2013 16:22, Peter Maydell ha scritto:
>> >
>> > That would create 10 empty files, and two files between one and three
>> > lines of code.  I would just put those in include/exec/user/abitypes.h.
> I would prefer not to add more code with TARGET ifdefs.
> (I have a vague plan to split up some of the current linux-user
> code which is #ifdefs in source files in linux-user into per
> target source files which make just pulls in as appropriate.)
> 
> Also, separate files in linux-user/foo encourage authors of
> new targets to think "do I need to put something in my new
> target's version of this?" whereas #ifdef TARGET_FOO in
> common source files don't.

I can't deny these are all good arguments.  I'm not sure if abitypes
would be the best or the worst place to start doing this conversion.

Paolo

> Riku's the linux-user maintainer, though...