From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: gleb@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org,
kvm@vger.kernel.org, Avi Kivity <avi.kivity@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 5/6] kvm: add PV MMIO
Date: Thu, 04 Apr 2013 16:56:11 +0200 [thread overview]
Message-ID: <515D948B.8080407@redhat.com> (raw)
In-Reply-To: <20130404131015.GF6467@redhat.com>
Il 04/04/2013 15:10, Michael S. Tsirkin ha scritto:
> > I would like Avi to comment on this, because I think this is not the
> > "memory-API approved" way of doing things. You need KVM to define its
> > own AddressSpace, and make KVM's listener use
> > memory_region_to_address_space to figure out if it is for PV MMIO.
> >
> > To handle accesses from TCG, the PV AddressSpace can simply have just an
> > alias to the actual MemoryRegion where the doorbell is.
>
> This is not really different from other eventfd flags like datamatch.
> Separate address space is not appropriate here.
> This is regular memory space, KVM eventfd simply has a flag that says
> "guest is well behaved so please make eventfd go faster".
Having a separate address space would match what you do in the kernel
though.
I just don't like functions with a dozen arguments... Can you just make
datamatch and pv a single flags argument, as is the case with the KVM API?
Paolo
next prev parent reply other threads:[~2013-04-04 14:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 10:39 [Qemu-devel] [PATCH v2 0/6] kvm: pci PORT IO MMIO and PV MMIO speed tests Michael S. Tsirkin
2013-04-04 10:40 ` [Qemu-devel] [PATCH v2 4/6] pci: add pci test device Michael S. Tsirkin
2013-04-04 10:40 ` [Qemu-devel] [PATCH v2 1/6] kvm: remove unused APIs Michael S. Tsirkin
2013-04-04 10:40 ` [Qemu-devel] [PATCH v2 2/6] kvm: support any size for pio eventfd Michael S. Tsirkin
2013-04-04 10:40 ` [Qemu-devel] [PATCH v2 3/6] kvm: support non datamatch ioeventfd Michael S. Tsirkin
2013-04-04 10:40 ` [Qemu-devel] [PATCH v2 6/6] pci-testdev: add pv mmio test Michael S. Tsirkin
2013-04-04 10:40 ` [Qemu-devel] [PATCH v2 5/6] kvm: add PV MMIO Michael S. Tsirkin
2013-04-04 12:46 ` Paolo Bonzini
2013-04-04 13:10 ` Michael S. Tsirkin
2013-04-04 14:56 ` Paolo Bonzini [this message]
2013-04-04 14:38 ` Michael S. Tsirkin
2013-04-04 12:50 ` Peter Maydell
2013-04-04 13:11 ` Michael S. Tsirkin
2013-04-04 14:23 ` Peter Maydell
2013-04-04 13:34 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515D948B.8080407@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi.kivity@gmail.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).