From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO2ea-0007me-IN for qemu-devel@nongnu.org; Fri, 05 Apr 2013 05:09:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UO2eV-0006Fj-Nr for qemu-devel@nongnu.org; Fri, 05 Apr 2013 05:09:48 -0400 Message-ID: <515E94CA.2020502@adacore.com> Date: Fri, 05 Apr 2013 11:09:30 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1365094053-1635-1-git-send-email-agraf@suse.de> In-Reply-To: <1365094053-1635-1-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] PPC: mac newworld: fix cpu NIP reset value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "qemu-ppc@nongnu.org list:PowerPC" , qemu-devel qemu-devel On 04/04/2013 06:47 PM, Alexander Graf wrote: > On -M mac99, we can run 970 CPUs. However, these CPUs define the initial > instruction pointer they start execution at as part of their bootup protocol, > so effectively it's up to the board to decide where they start. > > This went unnoticed, because they used to boot at the same location our flash > was mapped to, but due to the recent reset changes our 970 CPUs want to reset > to 0x100 now, which is always a 0 instruction. > This is one of the regressions introduced by my patch, thanks for fixing it. Reviewed-by: Fabien Chouteau > Set the initial IP to something reasonable for -M mac99. > > Signed-off-by: Alexander Graf > --- > hw/ppc/mac_newworld.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c > index a08a6b2..ca7d98f 100644 > --- a/hw/ppc/mac_newworld.c > +++ b/hw/ppc/mac_newworld.c > @@ -126,6 +126,8 @@ static void ppc_core99_reset(void *opaque) > PowerPCCPU *cpu = opaque; > > cpu_reset(CPU(cpu)); > + /* 970 CPUs want to get their initial IP as part of their boot protocol */ > + cpu->env.nip = PROM_ADDR + 0x100; > } > > /* PowerPC Mac99 hardware initialisation */ > -- Fabien Chouteau