From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
To: Roland Dreier <roland@kernel.org>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Yishai Hadas <yishaih@mellanox.com>,
LKML <linux-kernel@vger.kernel.org>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Sean Hefty <sean.hefty@intel.com>,
Christoph Lameter <cl@linux.com>
Subject: Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag
Date: Fri, 05 Apr 2013 16:51:20 -0400 [thread overview]
Message-ID: <515F3948.40205@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAL1RGDU2jtrRrxi6srsH_ADiYGvJbCpCT3UvoLGTX3cvQ=s0kQ@mail.gmail.com>
Sorry, I was wrong. ignore the comments about cgroups. That's still
broken. (i.e. trying to register RDMA memory while using a cgroup swap
limit cause the process get killed).
But the GIFT flag patch works (my understanding is that GIFT flag allows
the adapter to transmit stale memory information, it does not have
anything to do with cgroups specifically).
Am I missing something? I was only testing the GIFT flag patch.
Note: I only turned it on - I did not verify the (non) consitency of the
memory that was transmitted.
- Michael
On 04/05/2013 04:43 PM, Roland Dreier wrote:
> On Fri, Apr 5, 2013 at 1:17 PM, Michael R. Hines
> <mrhines@linux.vnet.ibm.com> wrote:
>> I also removed the IBV_*_WRITE flags on the sender-side and activated
>> cgroups with the "memory.memsw.limit_in_bytes" activated and the migration
>> with RDMA also succeeded without any problems (both with *and* without GIFT
>> also worked).
> Not sure I'm interpreting this correctly. Are you saying that things
> worked without actually setting the GIFT flag? In which case why are
> we adding this flag?
>
> - R.
>
next prev parent reply other threads:[~2013-04-05 20:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 15:51 [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag Michael S. Tsirkin
2013-04-02 15:51 ` Michael S. Tsirkin
2013-04-02 16:57 ` Roland Dreier
2013-04-02 17:05 ` Michael S. Tsirkin
2013-04-02 22:17 ` Michael R. Hines
2013-04-03 16:07 ` Michael S. Tsirkin
2013-04-05 20:17 ` Michael R. Hines
2013-04-05 20:43 ` Roland Dreier
2013-04-05 20:51 ` Michael R. Hines [this message]
2013-04-05 21:03 ` Roland Dreier
2013-04-05 21:32 ` Michael R. Hines
2013-04-09 19:03 ` Michael S. Tsirkin
2013-04-10 1:26 ` Michael R. Hines
2013-04-10 3:24 ` Michael S. Tsirkin
2013-04-10 4:32 ` Michael R. Hines
2013-04-10 5:32 ` Michael S. Tsirkin
2013-04-10 15:48 ` Michael R. Hines
2013-04-10 15:05 ` Michael S. Tsirkin
2013-04-10 16:28 ` Michael R. Hines
2013-04-09 19:09 ` Michael S. Tsirkin
2013-04-05 20:54 ` Michael R. Hines
2013-04-09 16:39 ` Michael S. Tsirkin
2013-04-09 17:56 ` Michael R. Hines
2013-04-09 19:00 ` Michael S. Tsirkin
2013-04-09 19:12 ` Michael S. Tsirkin
2013-04-09 20:34 ` Michael S. Tsirkin
2013-04-09 20:37 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515F3948.40205@linux.vnet.ibm.com \
--to=mrhines@linux.vnet.ibm.com \
--cc=cl@linux.com \
--cc=hal.rosenstock@gmail.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).