From: Thomas Huth <thuth@redhat.com>
To: Bug 1643537 <1643537@bugs.launchpad.net>,
qemu-devel@nongnu.org,
Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>
Subject: Re: [Qemu-devel] [Bug 1643537] [NEW] target-ppc/int_helper.c: 2 * bad array index
Date: Mon, 21 Nov 2016 14:23:25 +0100 [thread overview]
Message-ID: <515d6ef7-df9f-8bae-f7bf-615c28c60aa2@redhat.com> (raw)
In-Reply-To: <20161121121617.5146.1948.malonedeb@wampee.canonical.com>
On 21.11.2016 13:16, dcb wrote:
> Public bug reported:
>
> 1.
>
> [qemu/target-ppc/int_helper.c:2575]: (error) Array 'reg.u16[8]' accessed
> at index 8, which is out of bounds.
>
> Source code is
>
> return reg->u16[8 - n];
>
> and
>
> qemu/target-ppc/cpu.h: uint16_t u16[8];
>
> but at least once, n is zero, for example line 2725 in the int_helper.c
> file:
>
> uint16_t sgnb = get_national_digit(b, 0);
That looks wrong, indeed. I guess it should be "7 - n" instead of
"8 - n"? Jose, could you please have a look at this?
Thomas
next prev parent reply other threads:[~2016-11-21 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 12:16 [Qemu-devel] [Bug 1643537] [NEW] target-ppc/int_helper.c: 2 * bad array index dcb
2016-11-21 13:23 ` Thomas Huth [this message]
2016-11-21 14:58 ` joserz
2016-11-21 15:15 ` [Qemu-devel] [Bug 1643537] " Thomas Huth
2016-12-07 8:40 ` Thomas Huth
2017-01-16 11:37 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515d6ef7-df9f-8bae-f7bf-615c28c60aa2@redhat.com \
--to=thuth@redhat.com \
--cc=1643537@bugs.launchpad.net \
--cc=joserz@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).