From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOiZL-0004eW-Uy for qemu-devel@nongnu.org; Sun, 07 Apr 2013 01:55:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOiZK-0001Vb-Q4 for qemu-devel@nongnu.org; Sun, 07 Apr 2013 01:55:11 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:58698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOiZJ-0001U8-Su for qemu-devel@nongnu.org; Sun, 07 Apr 2013 01:55:10 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 7 Apr 2013 11:21:19 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 0D0E0394004F for ; Sun, 7 Apr 2013 11:25:02 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r375swLN65404980 for ; Sun, 7 Apr 2013 11:24:58 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r375t1vr023137 for ; Sun, 7 Apr 2013 15:55:01 +1000 Message-ID: <51610A2A.2090408@linux.vnet.ibm.com> Date: Sun, 07 Apr 2013 13:54:50 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1364903250-10429-1-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1364903250-10429-1-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V11 00/17] qmp/hmp interfaces for internal snapshot info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com Hi, Kevin Except the comments from Eric for better code comments, do you think other things need improved? Modified patches is addressed as following, I hope fix all in next version, to avoid using more time of reviewer. > > v11: > General change: > 5/17: check if snapshot > 0 on success in caller, add comments on the > function says that caller need to check it on success. > 7/17: check if snapshot > 0 on success before set info->has_snapshots. > > Address Eric's comments: > 5/17: use error_setg_errno instead of strerror(). > 12/17: also move bdrv_snapshot_dump() since it need to be changed using > GString later. > 13/17: using GString as buffer. > 14/17: using GString to dump snapshot info. > 16/17: using GString to dump image info. > > Address Kevin's comments: > 11/17: return void for bdrv_query_info(). > 17/17: spell fix in help message, using parameter "-v" to show > verbose info. > -- Best Regards Wenchao Xia