From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPEfb-0002by-4L for qemu-devel@nongnu.org; Mon, 08 Apr 2013 12:11:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPEfW-0004Rb-Bw for qemu-devel@nongnu.org; Mon, 08 Apr 2013 12:11:47 -0400 Message-ID: <5162EC3C.2050208@suse.de> Date: Mon, 08 Apr 2013 18:11:40 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1365436306-20152-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1365436306-20152-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-moxie: Fix VMState registration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, Anthony Green , Juan Quintela , qemu-devel@nongnu.org, patches@linaro.org Am 08.04.2013 17:51, schrieb Peter Maydell: > Register the CPU VMState in the correct way, via cpu_class_set_vmsd(), > rather than doing it in two different wrong ways (once by providing > cpu_save and cpu_load functions, and once by setting the vmsd field in > DeviceClass). >=20 > Signed-off-by: Peter Maydell > --- > Having just revamped the target-arm vmstate code I now have a > better grasp of how it should work, so I noticed we didn't quite > get moxie right. Not really very tested since I couldn't find a test > image to try, but should work better than the previous code... Reviewed-by: Andreas F=E4rber Thanks for fixing this, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg