From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPFQo-0001BL-Re for qemu-devel@nongnu.org; Mon, 08 Apr 2013 13:00:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPFQn-0008Di-7V for qemu-devel@nongnu.org; Mon, 08 Apr 2013 13:00:34 -0400 Received: from greensocs.com ([87.106.252.221]:33112 helo=s15328186.onlinehome-server.info) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPFQn-0008DG-1C for qemu-devel@nongnu.org; Mon, 08 Apr 2013 13:00:33 -0400 Message-ID: <5162F7A9.2040000@greensocs.com> Date: Mon, 08 Apr 2013 19:00:25 +0200 From: =?ISO-8859-1?Q?KONRAD_Fr=E9d=E9ric?= MIME-Version: 1.0 References: <1365085745-14385-1-git-send-email-fred.konrad@greensocs.com> <87mwtdgfb9.fsf@codemonkey.ws> In-Reply-To: <87mwtdgfb9.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: cornelia.huck@de.ibm.com, peter.maydell@linaro.org, mark.burton@greensocs.com, qemu-devel@nongnu.org On 05/04/2013 17:36, Anthony Liguori wrote: > fred.konrad@greensocs.com writes: > >> From: KONRAD Frederic >> >> This is the next part of virtio-refactoring. >> >> Basically it creates virtio-serial device which extends virtio-device. >> Then a virtio-serial can be connected on a virtio-bus. >> virtio-serial-pci, virtio-serial-s390 and virtio-serial-ccw are created too, >> they extend respectively virtio-pci, virtio-s390-device, virtio-ccw-device and >> have a virtio-serial. >> >> You can checkout my branch here: >> >> git://project.greensocs.com/qemu-virtio.git virtio-serial-v5 >> >> Note that it is nearly the same series as virtio-blk and virtio-scsi >> refactoring. > /home/aliguori/build/qemu/x86_64-softmmu/qemu-system-x86_64 -kernel /usr/local/share/qemu-jeos/kernel-x86_64-pc -initrd .tmp-11584/initramfs-11584.img.gz -device isa-debug-exit -append console=ttyS0 seed=42872 -nographic -enable-kvm -hda .tmp-11584/disk-11584.img -M pc-0.13 -drive file=.tmp-11584/disk-11584.img,if=virtio,snapshot=on -device virtio-balloon-pci -device virtio-serial -net nic,model=virtio -net user -pidfile .tmp-11584/pidfile-11584.pid -qmp unix:.tmp-11584/qmpsock-11584.sock,server,nowait > qemu-system-x86_64: -device virtio-serial: No 'virtio-bus' bus found for > device 'virtio-serial' > > I think we need to go back and name the devices 'virtio-serial-device' > et al to avoid breaking aliases. > > Regards, > > Anthony Liguori Hi Anthony, I'm making a patch for that, and I'm wondering if the name in register_savevm must be changed too? eg for virtio-balloon: - register_savevm(qdev, "virtio-balloon", -1, 1, + register_savevm(qdev, TYPE_VIRTIO_BALLOON, -1, 1, virtio_balloon_save, virtio_balloon_load, s); with TYPE_VIRTIO_BALLOON "virtio-balloon-device"? Thanks, Fred