From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60735)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1UPFeN-0006A8-R0
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 13:14:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1UPFeI-0005SX-BV
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 13:14:35 -0400
Received: from greensocs.com ([87.106.252.221]:46922
	helo=s15328186.onlinehome-server.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1UPFeI-0005S9-49
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 13:14:30 -0400
Message-ID: <5162FAEE.1060208@greensocs.com>
Date: Mon, 08 Apr 2013 19:14:22 +0200
From: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1365085745-14385-1-git-send-email-fred.konrad@greensocs.com>
	<87mwtdgfb9.fsf@codemonkey.ws> <5162F7A9.2040000@greensocs.com>
	<CAFEAcA_7qR=JSGWZkjc=YkGAsLvUh_Cx7v1s4fFP8yCv=S3hEQ@mail.gmail.com>
In-Reply-To: <CAFEAcA_7qR=JSGWZkjc=YkGAsLvUh_Cx7v1s4fFP8yCv=S3hEQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: cornelia.huck@de.ibm.com, Anthony Liguori <aliguori@us.ibm.com>, mark.burton@greensocs.com, qemu-devel@nongnu.org

On 08/04/2013 19:03, Peter Maydell wrote:
> On 8 April 2013 18:00, KONRAD Fr=C3=A9d=C3=A9ric <fred.konrad@greensocs=
.com> wrote:
>> I'm making a patch for that, and I'm wondering if the name in
>> register_savevm must be changed too?
>>
>> eg for virtio-balloon:
>>
>> -    register_savevm(qdev, "virtio-balloon", -1, 1,
>> +    register_savevm(qdev, TYPE_VIRTIO_BALLOON, -1, 1,
>>                       virtio_balloon_save, virtio_balloon_load, s);
>>
>> with TYPE_VIRTIO_BALLOON "virtio-balloon-device"?
> You specifically don't want to change the register_savevm name,
> because otherwise you'll break migration (we use the ID string
> to identify what incoming migration data is).
>
> -- PMM
Ok, you mean migration between two qemu's version with the different name=
?