From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52064)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPSle-0004yz-S2
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 03:15:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPSld-0002tg-FD
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 03:14:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30047)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPSld-0002tG-7e
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 03:14:57 -0400
Message-ID: <5163BFE3.3010507@redhat.com>
Date: Tue, 09 Apr 2013 09:14:43 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1364519296-31883-1-git-send-email-nab@linux-iscsi.org>
	<1364519296-31883-2-git-send-email-nab@linux-iscsi.org>
	<87bo9oheex.fsf@codemonkey.ws>
In-Reply-To: <87bo9oheex.fsf@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH-v2 1/2] virtio-scsi: create VirtIOSCSICommon
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: kvm-devel <kvm@vger.kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, "Nicholas A. Bellinger" <nab@linux-iscsi.org>, lf-virt <virtualization@lists.linux-foundation.org>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, target-devel <target-devel@vger.kernel.org>, Stefan Hajnoczi <stefanha@redhat.com>, Asias He <asias@redhat.com>

Il 08/04/2013 23:59, Anthony Liguori ha scritto:
> > This patch refactors existing virtio-scsi code into VirtIOSCSICommon
> > in order to allow virtio_scsi_init_common() to be used by both internal
> > virtio_scsi_init() and external vhost-scsi-pci code.
> >
> > Changes in Patch-v2:
> >    - Move ->get_features() assignment to virtio_scsi_init() instead of
> >      virtio_scsi_init_common()
> 
> Any reason we're not doing this as a QOM base class?
> 
> Similiar to how the in-kernel PIT/PIC work using a common base class...

Because when the patch was written virtio-scsi was not a QOM class.

Paolo