From: "KONRAD Frédéric" <fred.konrad@greensocs.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Hans de Goede <hdegoede@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
Date: Tue, 09 Apr 2013 11:30:47 +0200 [thread overview]
Message-ID: <5163DFC7.4050606@greensocs.com> (raw)
In-Reply-To: <5163D31F.5060901@redhat.com>
On 09/04/2013 10:36, Paolo Bonzini wrote:
> Il 09/04/2013 10:22, Hans de Goede ha scritto:
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> hw/9pfs/virtio-9p-device.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> Ouch, /me installs libcap-ng-devel.
>
> Thanks.
>
> Paolo
>
>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
>> index 43f930e..b476b81 100644
>> --- a/hw/9pfs/virtio-9p-device.c
>> +++ b/hw/9pfs/virtio-9p-device.c
>> @@ -12,11 +12,11 @@
>> */
>>
>> #include "hw/virtio/virtio.h"
>> +#include "hw/virtio/virtio-9p.h"
[..]
>> #include "virtio-9p.h"
Is that normal?
We have two virtio-9p.h:
./hw/9pfs/virtio-9p.h
./include/hw/virtio/virtio-9p.h
which can be confusing.
is it not better to re-rename virtio-9p.h => virtio-9p-device.h?
>> -#include "virtio-9p-device.h"
>>
>>
>
next prev parent reply other threads:[~2013-04-09 9:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 8:22 [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge Hans de Goede
2013-04-09 8:36 ` Paolo Bonzini
2013-04-09 9:30 ` KONRAD Frédéric [this message]
2013-04-09 9:36 ` Paolo Bonzini
2013-04-09 11:15 ` KONRAD Frédéric
2013-04-09 11:30 ` Markus Armbruster
2013-04-09 11:48 ` Paolo Bonzini
2013-04-09 19:13 ` Anthony Liguori
2013-04-09 20:27 ` KONRAD Frédéric
2013-04-09 20:57 ` Anthony Liguori
2013-04-09 21:28 ` KONRAD Frédéric
2013-04-15 16:52 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163DFC7.4050606@greensocs.com \
--to=fred.konrad@greensocs.com \
--cc=hdegoede@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).