From: Paolo Bonzini <pbonzini@redhat.com>
To: li guang <lig.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
aliguori@us.ibm.com, afaerber@suse.de, stefanha@gmail.com
Subject: Re: [Qemu-devel] [PATCH][RFC v2 3/7] vl: create power chip device
Date: Tue, 09 Apr 2013 13:06:37 +0200 [thread overview]
Message-ID: <5163F63D.8090109@redhat.com> (raw)
In-Reply-To: <1365495988.9553.62.camel@liguang.fnst.cn.fujitsu.com>
Il 09/04/2013 10:26, li guang ha scritto:
> > qemu_system_suspend_request, qemu_register_suspend_notifier
> > for S0->S3
> >
> > qemu_system_wakeup_request, qemu_register_wakeup_notifier
> > for S3->S0
> >
> > qemu_system_powerdown_request, qemu_register_powerdown_notifier
> > for Sx->S5
> >
> > and the reset mechanism for S5->S0.
>
> Yep, I'm trying to supersede these functions
> by my power chip emulation.
Then I explained in my other message why this is wrong. The API may
well be "bad" (if so, please explain why), but at least it is the right
tool to model this. QEMU models abstract concepts (memory, timers,
powerdown) with APIs, not with devices.
Paolo
next prev parent reply other threads:[~2013-04-09 11:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 4:28 [Qemu-devel] [PATCH][RFC v2 0/7] implement power chip liguang
2013-04-05 4:28 ` [Qemu-devel] [PATCH][RFC v2 1/7] hw/irq: move struct IRQState to irq.h liguang
2013-04-05 8:34 ` Peter Maydell
2013-04-05 8:39 ` li guang
2013-04-05 4:28 ` [Qemu-devel] [PATCH][RFC v2 2/7] hw/power: add main power chip implementation liguang
2013-04-05 8:35 ` Peter Maydell
2013-04-05 8:45 ` li guang
2013-04-05 9:23 ` Peter Maydell
2013-04-08 0:32 ` li guang
2013-04-08 9:21 ` Peter Maydell
2013-04-09 8:14 ` li guang
2013-04-09 8:29 ` Paolo Bonzini
2013-04-05 4:28 ` [Qemu-devel] [PATCH][RFC v2 3/7] vl: create power chip device liguang
2013-04-05 11:48 ` Paolo Bonzini
2013-04-08 0:18 ` li guang
2013-04-08 9:53 ` Paolo Bonzini
2013-04-09 7:34 ` li guang
2013-04-09 7:43 ` Paolo Bonzini
2013-04-09 8:26 ` li guang
2013-04-09 11:06 ` Paolo Bonzini [this message]
2013-04-10 0:09 ` li guang
2013-04-10 9:40 ` Paolo Bonzini
2013-04-10 12:09 ` Andreas Färber
2013-04-10 13:41 ` guang li
2013-04-10 13:52 ` Paolo Bonzini
2013-04-11 1:30 ` li guang
2013-04-16 20:45 ` Anthony Liguori
2013-04-17 0:07 ` li guang
2013-04-05 4:28 ` [Qemu-devel] [PATCH][RFC v2 4/7] sysemu: remove PowerReason in sysemu.h liguang
2013-04-05 4:28 ` [Qemu-devel] [PATCH][RFC v2 5/7] qdev: add power_signal_in for DeviceState liguang
2013-04-05 4:28 ` [Qemu-devel] [PATCH][RFC v2 6/7] ich9: refactor wakeup/reset function liguang
2013-04-05 4:28 ` [Qemu-devel] [PATCH][RFC v2 7/7] vl: run power_management liguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163F63D.8090109@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).