From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59402)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPWYJ-000182-GH
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:17:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPWYE-0006kv-Uf
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:17:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40241)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPWYE-0006kn-Di
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:17:22 -0400
Message-ID: <5163F8B0.1010100@redhat.com>
Date: Tue, 09 Apr 2013 13:17:04 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1365172636-28628-1-git-send-email-imammedo@redhat.com>
	<1365172636-28628-6-git-send-email-imammedo@redhat.com>
	<20130408194501.GG2719@otherpad.lan.raisama.net>
	<20130409121313.6566767d@nial.usersys.redhat.com>
In-Reply-To: <20130409121313.6566767d@nial.usersys.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 05/22] cpu: call
 cpu_synchronize_post_init() from CPUClass.realize() if hotplugged
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: aliguori@us.ibm.com, Eduardo Habkost <ehabkost@redhat.com>, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, afaerber@suse.de, lig.fnst@cn.fujitsu.com, rth@twiddle.net

Il 09/04/2013 12:13, Igor Mammedov ha scritto:
> > Why you didn't include it on libqemustub instead? You said on a previous
> > thread that it is not possible to include all of kvm-stub.c into
> > libqemustub. Why not?
> 
> It wasn't possible, but after this patch it's, I guess.
> Paolo objected to including CPU related stuff in libqemustub, hence
> this hunk in Makefile.

I objected to including target-specific stuff, but general APIs
certainly can go there.  That is certainly the case for kvm-stub.c.

Still, please make this a separate patch.

Paolo