From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPWfy-0006WM-99 for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:25:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPWfx-0000js-2e for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:25:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPWfw-0000jl-Px for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:25:21 -0400 Message-ID: <5163FA8F.5060706@redhat.com> Date: Tue, 09 Apr 2013 13:25:03 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1365172636-28628-1-git-send-email-imammedo@redhat.com> <1365172636-28628-13-git-send-email-imammedo@redhat.com> In-Reply-To: <1365172636-28628-13-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/22] cpu: add helper cpu_exists(), to check if CPU with specified id exists List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: aliguori@us.ibm.com, ehabkost@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, afaerber@suse.de, lig.fnst@cn.fujitsu.com, rth@twiddle.net Il 05/04/2013 16:37, Igor Mammedov ha scritto: > ... it should be used only on slow path since it does recursive search > on /machine QOM tree for objects of TYPE_CPU > > Signed-off-by: Igor Mammedov > --- > include/qom/cpu.h | 10 ++++++++++ > qom/cpu.c | 21 +++++++++++++++++++++ > 2 files changed, 31 insertions(+) > > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > index 0d33009..5cac79b 100644 > --- a/include/qom/cpu.h > +++ b/include/qom/cpu.h > @@ -227,6 +227,16 @@ void run_on_cpu(CPUState *cpu, void (*func)(void *data), void *data); > */ > CPUState *qemu_get_cpu(int index); > > +/** > + * cpu_exists: > + * @id - guest exposed CPU ID to lookup > + * > + * Search for CPU with specified ID. > + * > + * Returns: true - CPU is found, false - CPU isn't found > + */ > +bool cpu_exists(int64_t id); > + > #ifndef CONFIG_USER_ONLY > > typedef void (*CPUInterruptHandler)(CPUState *, int); > diff --git a/qom/cpu.c b/qom/cpu.c > index a54d4d1..46b77d3 100644 > --- a/qom/cpu.c > +++ b/qom/cpu.c > @@ -24,6 +24,27 @@ > #include "qemu/notify.h" > #include "sysemu/sysemu.h" > > +static int cpu_exist_cb(Object *obj, void *opaque) > +{ > + int64_t id = *(int64_t *)opaque; > + Object *cpu_obj = object_dynamic_cast(obj, TYPE_CPU); > + > + if (cpu_obj) { > + CPUState *cpu = CPU(cpu_obj); > + CPUClass *klass = CPU_GET_CLASS(cpu); > + > + if (klass->get_firmware_id && klass->get_firmware_id(cpu) == id) { > + return 1; > + } > + } > + return object_child_foreach(obj, cpu_exist_cb, opaque); > +} > + > +bool cpu_exists(int64_t id) > +{ > + return cpu_exist_cb(qdev_get_machine(), &id) ? true : false; > +} > + > /* CPU hot-plug notifiers */ > static NotifierList cpu_added_notifiers = > NOTIFIER_LIST_INITIALIZER(cpu_add_notifiers); > Reviewed-by: Paolo Bonzini