From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPWrK-0000BL-EG for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:37:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPWrH-0004pp-Lc for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:37:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPWrH-0004pk-D6 for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:37:03 -0400 Message-ID: <5163FD4E.8050206@redhat.com> Date: Tue, 09 Apr 2013 13:36:46 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1365172636-28628-1-git-send-email-imammedo@redhat.com> <1365172636-28628-9-git-send-email-imammedo@redhat.com> <1365387208.5674.38.camel@liguang.fnst.cn.fujitsu.com> <20130408133256.4f4a3fc8@nial.usersys.redhat.com> In-Reply-To: <20130408133256.4f4a3fc8@nial.usersys.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: aliguori@us.ibm.com, ehabkost@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, afaerber@suse.de, li guang , rth@twiddle.net Il 08/04/2013 13:32, Igor Mammedov ha scritto: >=20 >> > This patch should be combined with [PATCH 07/22] >> >=20 >> > =E5=9C=A8 2013-04-05=E4=BA=94=E7=9A=84 16:37 +0200=EF=BC=8CIgor Mamm= edov=E5=86=99=E9=81=93=EF=BC=9A >>> > > Signed-off-by: Igor Mammedov >>> > > --- >>> > > hw/ioapic_common.c | 2 +- >>> > > 1 file changed, 1 insertion(+), 1 deletion(-) >>> > >=20 >>> > > diff --git a/hw/ioapic_common.c b/hw/ioapic_common.c >>> > > index d4aff29..561b987 100644 >>> > > --- a/hw/ioapic_common.c >>> > > +++ b/hw/ioapic_common.c >>> > > @@ -59,7 +59,7 @@ static int ioapic_dispatch_post_load(void *opaq= ue, int >>> > > version_id)=20 >>> > > static int ioapic_init_common(SysBusDevice *dev) >>> > > { >>> > > - IOAPICCommonState *s =3D FROM_SYSBUS(IOAPICCommonState, dev)= ; >>> > > + IOAPICCommonState *s =3D IOAPIC_COMMON(dev); >>> > > IOAPICCommonClass *info; >>> > > static int ioapic_no; >>> > > =20 >> >=20 >> >=20 >> >=20 > sure, will do this on the next respin. Actually no, why? It's two different files. Paolo